This repository has been archived by the owner on Nov 8, 2019. It is now read-only.
Use dynamic IL instead of reflection. #157
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Improves performance by some orders of magnitude. At least once the Encoder is cached or on the second call of auto-encoder.
matthid
added a commit
to matthid/CSGO-Demo-Manager
that referenced
this pull request
Aug 3, 2019
Includes various perf fixes bundles MangelMaxime/Thoth#157
matthid
commented
Aug 9, 2019
matthid
added a commit
to matthid/CSGO-Demo-Manager
that referenced
this pull request
Aug 10, 2019
Includes various perf fixes bundles MangelMaxime/Thoth#157
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR improves performance by some orders of magnitude. At least once the Encoder is cached or on the second call of auto-encoder.
A similar change could probably by done in the decoder, but I'm only using encoders in my scenario.
I tested this on my scenario, but there might be some edge cases where this approach doesn't work, or we need to emit slightly different IL. In these cases, the current code writes an error to the console and uses a fallback logic. We should change this particular logic before merging. Any ideas?