Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[SPIKE] Adding aggregations #780

Draft
wants to merge 2 commits into
base: main
Choose a base branch
from
Draft

[SPIKE] Adding aggregations #780

wants to merge 2 commits into from

Conversation

matt-bernhardt
Copy link
Member

@matt-bernhardt matt-bernhardt commented Feb 2, 2024

This is a prototypal body of work, and may not resolve to a formal PR.

Developer

  • All new ENV is documented in README
  • All new ENV has been added to Heroku Pipeline, Staging and Prod
  • ANDI or Wave has been run in accordance to
    our guide and
    all issues introduced by these changes have been resolved or opened as new
    issues (link to those issues in the Pull Request details above)
  • Stakeholder approval has been confirmed (or is not needed)

Code Reviewer

  • The commit message is clear and follows our guidelines
    (not just this pull request message)
  • There are appropriate tests covering any new functionality
  • The documentation has been updated or is unnecessary
  • The changes have been verified
  • New dependencies are appropriate or there were no changes

Requires database migrations?

YES | NO

Includes new or updated dependencies?

YES | NO

@matt-bernhardt matt-bernhardt changed the title Adding aggregations [SPIKE] Adding aggregations Feb 2, 2024
@mitlib mitlib temporarily deployed to timdex-pr-780 February 2, 2024 15:48 Inactive
@matt-bernhardt matt-bernhardt force-pushed the more-aggregations branch 3 times, most recently from a97ec56 to 0db0233 Compare February 12, 2024 21:18
This is the input side of the equation only. Reporting back based on this field, as an aggregation, is part of a separate commit.
This is the aggregation only. Adding the filter will come next.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants