Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add search summary panel #116

Closed
wants to merge 1 commit into from
Closed

Conversation

jazairi
Copy link
Contributor

@jazairi jazairi commented Feb 14, 2024

Why these changes are being introduced:

It would be helpful if users could see what filters they've applied to a search directly below the search bar, which would also provide another path to remove filters.

Relevant ticket(s):

https://mitlibraries.atlassian.net/browse/GDT-142

How this addresses that need:

This provides the requested panel. We had been calling this a "filter removal" panel, but I ended up naming it "search summary" to avoid any confusion with the filter sidebar.

Side effects of this change:

The "You searched for" list has been removed, as this feature replaces it.

Developer

  • All new ENV is documented in README
  • All new ENV has been added to Heroku Pipeline, Staging and Prod
  • ANDI or Wave has been run in accordance to
    our guide and
    all issues introduced by these changes have been resolved or opened as new
    issues (link to those issues in the Pull Request details above)
  • Stakeholder approval has been confirmed (or is not needed)

Code Reviewer

  • The commit message is clear and follows our guidelines
    (not just this pull request message)
  • There are appropriate tests covering any new functionality
  • The documentation has been updated or is unnecessary
  • The changes have been verified
  • New dependencies are appropriate or there were no changes

Requires database migrations?

NO

Includes new or updated dependencies?

NO

Why these changes are being introduced:

It would be helpful if users could see what filters they've
applied to a search directly below the search bar, which would
also provide another path to remove filters.

Relevant ticket(s):

https://mitlibraries.atlassian.net/browse/GDT-142

How this addresses that need:

This provides the requested panel. We had been calling this a
"filter removal" panel, but I ended up naming it "search summary"
to avoid any confusion with the filter sidebar.

Side effects of this change:

The "You searched for" list has been removed, as this feature
replaces it.
@mitlib mitlib temporarily deployed to timdex-ui-pi-gdt-142-fi-wrknf3 February 14, 2024 22:59 Inactive
@jazairi jazairi closed this Feb 14, 2024
@jazairi
Copy link
Contributor Author

jazairi commented Feb 14, 2024

Closing this for now, as I realized I missed a couple of details.

@jazairi jazairi deleted the gdt-142-filter-removal-panel branch February 14, 2024 23:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants