Make requested changes to the copyright and license fields

[jazairi]

Why these changes are being introduced:

Stakeholders have requested that we preselect the 'author' copyright value, and make the license field conditionally required when that copyright value is selected.

Relevant ticket(s):

• ETD-627

How this addresses that need:

This adds the selected property to the desired option in the copyright field. It also updates the conditionalLicenseField function to toggle the required property on the license field when it is shown or hidden.

Side effects of this change:

• Past experience has made me wary of toggling the required prop in this way. However, it is generally reliable under a single binary condition (either the 'Author' copyright value is selected, or it isn't). I haven't noticed any issues in click-testing.
• selected is tied to a value, so in this case we are preselecting the first option. This corresponds to 'Author' in both staging and prod, but it would be better to make an explicit association. If the data were to change order somehow, the wrong copyright holder could be preselected.

Developer

• All new ENV is documented in README
• All new ENV has been added to Heroku Pipeline, Staging and Prod
• ANDI or Wave has been run in accordance to
  our guide and
  all issues introduced by these changes have been resolved or opened as new
  issues (link to those issues in the Pull Request details above)
• Stakeholder approval has been confirmed (or is not needed)

Code Reviewer

• The commit message is clear and follows our guidelines
  (not just this pull request message)
• There are appropriate tests covering any new functionality
• The documentation has been updated or is unnecessary
• The changes have been verified
• New dependencies are appropriate or there were no changes

Requires database migrations?

NO

Includes new or updated dependencies?

NO

[coveralls]

coverage: 98.313%. remained the same
when pulling 671efa1 on etd-627-update-copyright
into 694d3e5 on main.

[JPrevost]

@jazairi It looks like we set the ID is consistent in the PR builds as well so while not ideal, it's probably a risk we can accept as there is little reason we'd be changing the Author copyright to be something inherently different under the good.

That said, I believe this ID is wrong as Author is ID 2 (in the PR build and prod at least).

[jazairi]

@JPrevost Thanks for pointing that out! While fixing that, I noticed that I'd forgotten to include license validation/required field indicator in the edit view, so I added that, too.

[JPrevost]

I wonder if for the edit view we can do something like selected: 2 if license.nil? (not real code). My reasoning is that because of the registrar data load pre-creating theses, I think most users hit the edit form and not the new form.

[jazairi]

Ah, good point. I'll see what options we have there.

[JPrevost]

This looks and works as expected.

I added a comment as to whether we can figure out how to make the feature work safely for the edit form. If not, I can approve as-is. But if we can make edit work safely (i.e. only override selection if no data exists for that field) that would be better.

[jazairi]

@JPrevost I think the latest commit addresses your concern about the edit form. It's a bit kludgy to preselect the associated copyright, but without that condition, that field would be blank if the thesis already had a copyright.

[JPrevost]

This works how I think it makes sense... let's hope when you check in with stakeholders it's what they meant :)

Thanks for taking the extra time to make the tweaks!