Update values for Employee Salary History merge field #89
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Why these changes are being introduced: After possible updates to data warehouse data coming in, it was determined that additional fields were needed to mint a unique merge field 'Key' for the Employee Salary History table. By adding the HR transaction reason and type, this is enough to gaurantee the merge field is unique. How this addresses that need: * Adds 'Related Salary Change Type' and 'Salary Change Reason' as fields for minting unique key Side effects of this change: * All records were truncated from Quickbase and recreated as this change effects the unique merge field Relevant ticket(s): * None
ghukill
commented
Jul 8, 2024
Comment on lines
+61
to
+66
| str(row.appointment_begin_date), | ||
| str(row.appointment_end_date), | ||
| str(row.hr_personnel_action), | ||
| str(row.hr_action_reason), | ||
| str(row.start_date), | ||
| str(row.end_date), |
There was a problem hiding this comment.
It was also learned that dates and/or reasons can be NULL coming from the data warehouse (again, maybe new?) and so stringify-ing them here just to be safe.
jonavellecuerdo
approved these changes
Jul 8, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose and background context
After possible updates to data warehouse data coming in, it was determined that additional fields were needed to mint a unique merge field 'Key' for the
Employee Salary Historytable. By adding the HR transaction reason and type, this is enough to gaurantee the merge field is unique.How this addresses that need:
Related Salary Change TypeandSalary Change Reasonas fields for minting unique keyHow can a reviewer manually see the effects of these changes?
Not readily doable. See updated test to observe new fields added to MD5 hashing for
Keyfield.Includes new or updated dependencies?
NO
Changes expectations for external applications?
What are the relevant tickets?
Developer
Code Reviewer(s)