Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose and background context
It was determined that columns used from the data warehouse, expected to be enduringly the same and unique, were changing across warehouse runs. These values were used for Quickbase merge fields, but this would not work if the values changed.
Values for tables
Employee Appointments
,Employee Salary History
, andEmployee Leave
were needed that uniquely identified the record/row, and would not change over time from warehouse runs.The solution was to follow a pattern already established in
Employee Leave
to create an MD5 hash of record values that are known to uniquely identify a record.For example, the following is the code that mints an MD5 hash for
Employee Appointments
:How can a reviewer manually see the effects of these changes?
New tests demonstrate how the utility function
md5_hash_from_values()
creates an MD5 hash from a list of strings. Each Transform task for these tables utilizes this to set aKey
field (naming convention from Quickbase) from a list of values. There are tests (example, example, example) for these transforms that show the value of theKey
field is expected given the input row data.Includes new or updated dependencies?
NO
Changes expectations for external applications?
NO
What are the relevant tickets?
Developer
Code Reviewer(s)