Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove end date as part of appointment unique key #202

Merged
merged 1 commit into from
Jan 6, 2025

Conversation

ghukill
Copy link
Collaborator

@ghukill ghukill commented Jan 6, 2025

Purpose and background context

An Employee Appointment end date was used as part of its enduring unique key in Quickbase, but this was flawed. When an appointment ended, the end date was changed from 2999-12-31 to the actual end date, changing the unique key, and effectively leaving an extra row in Quickbase.

By removing the end date as part of the employee appointment key, we get an enduringly unique key that can be used for updates to pre-existing rows (e.g. the end date changes).

Includes new or updated dependencies?

NO

Changes expectations for external applications?

NO

What are the relevant tickets?

  • None

Developer

  • All new ENV is documented in README
  • All new ENV has been added to staging and production environments
  • All related Jira tickets are linked in commit message(s)
  • Stakeholder approval has been confirmed (or is not needed)

Code Reviewer(s)

  • The commit message is clear and follows our guidelines (not just this PR message)
  • There are appropriate tests covering any new functionality
  • The provided documentation is sufficient for understanding any new functionality introduced
  • Any manual tests have been performed or provided examples verified
  • New dependencies are appropriate or there were no changes

Why these changes are being introduced:

An employee appointment's end date was used as part of its
enduring unique key in Quickbase, but this was flawed.  When
an appointment ended, the end date was changed from 2999-12-31 to
the actual end date, changing the unique key, and effectively
leaving an extra row in Quickbase.

How this addresses that need:

Removing the end date as part of the employee appointment key is
sufficient to make them enduringly unique.

Side effects of this change:
* This required dropping and recreating the Employee Appointments
table via a manual run, but otherwise no changes.

Relevant ticket(s):
* None
@ghukill ghukill merged commit 159084c into main Jan 6, 2025
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants