Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

HRQB 57 - many-to-one relationships for LibHR table #201

Merged
merged 1 commit into from
Nov 26, 2024

Conversation

ghukill
Copy link
Collaborator

@ghukill ghukill commented Nov 26, 2024

Purpose and background context

This PR allows the LibHR Employee Appointments table to have multiple rows for employee and/or headcount ID (HC ID). This allows a headcount ID like L-001 to have multiple rows, where new columns Begin Date and End Date will show when that headcount ID was applied and to whom.

In turn, this supports reports in Quickbase that show the employee's associated with a single headcount ID, vacancy reports, etc.

Includes new or updated dependencies?

YES: cryptography had a required update for safety vulnerability

NOTE: other dependencies were not updated at this time, as updates to mypy and ruff are bringing lots of linting errors. This will be handled in a future maintenance update.

Changes expectations for external applications?

YES: Quickbase receiving new data

What are the relevant tickets?

Developer

  • All new ENV is documented in README
  • All new ENV has been added to staging and production environments
  • All related Jira tickets are linked in commit message(s)
  • Stakeholder approval has been confirmed (or is not needed)

Code Reviewer(s)

  • The commit message is clear and follows our guidelines (not just this PR message)
  • There are appropriate tests covering any new functionality
  • The provided documentation is sufficient for understanding any new functionality introduced
  • Any manual tests have been performed or provided examples verified
  • New dependencies are appropriate or there were no changes

Why these changes are being introduced:

It was determined that the LibHR Employee Appointments table was the
best way to represent vacancies for internal Library HR headcount
ids.

How this addresses that need:
* Added begin and end dates, allowing for multiple rows for a headcount
id
* Added Internal Position Title column to indicate the position title
is internal to Library HR, and not from the data warehouse

Side effects of this change:
* LibHR table allows for multiple rows for a person and/or headcount
id

Relevant ticket(s):
* https://mitlibraries.atlassian.net/browse/HRQB-57
@ghukill ghukill requested a review from ehanson8 November 26, 2024 16:57
@ghukill ghukill merged commit cef85b8 into main Nov 26, 2024
3 of 4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants