Merge pull request #126 from MITLibraries/HRQB-44-resolve-lingering-u…

…psert-issues HRQB 44 - Drop null values from salary change types
MITLibraries · Aug 5, 2024 · f7c8826 · f7c8826
2 parents 3a304fa + 72dd762
commit f7c8826
Showing 1 changed file with 2 additions and 1 deletion.
diff --git a/hrqb/tasks/salary_change_types.py b/hrqb/tasks/salary_change_types.py
@@ -17,11 +17,12 @@ def requires(self) -> list[luigi.Task]:  # pragma: nocover
 
     def get_dataframe(self) -> pd.DataFrame:
         fields = {"hr_personnel_action": "Salary Change Type"}
-        return (
+        salary_types_df = (
             self.single_input_dataframe[fields.keys()]
             .drop_duplicates()
             .rename(columns=fields)
         )
+        return salary_types_df[~salary_types_df["Salary Change Type"].isna()]
 
 
 class LoadSalaryChangeTypes(QuickbaseUpsertTask):