Skip to content

Commit

Permalink
Update README.md
Browse files Browse the repository at this point in the history
  • Loading branch information
seyuf authored Mar 15, 2022
1 parent 83bde40 commit 07850ff
Showing 1 changed file with 1 addition and 2 deletions.
3 changes: 1 addition & 2 deletions README.md
Original file line number Diff line number Diff line change
Expand Up @@ -347,7 +347,7 @@ To build static content for languagages other than en_US see (https://forum.madi
## Magento security scanners
Security scan actions should and must (in case of the modules scanner) be launched after a build job see example [here](https://github.com/seyuf/m2-dev-github-actions/blob/49c3d996d65f93fe438c5a245e4dd798e4c7d422/.github/workflows/main.yml#L37)
***Security scan actions must*** (in case of the modules scanner) be launched ***after a build*** job see example [here](https://github.com/seyuf/m2-dev-github-actions/blob/49c3d996d65f93fe438c5a245e4dd798e4c7d422/.github/workflows/main.yml#L37) as the magerun module needs the ```app/etc/config.php``` file to be present.
To scan the magento 2 files for common vulnerabilities using mwscan, the job can be set up as follows
Expand Down Expand Up @@ -390,7 +390,6 @@ For magento 2.4.x
env:
COMPOSER_AUTH: ${{secrets.COMPOSER_AUTH}}
with:
php: '7.4'
process: 'security-scan-modules'
elasticsearch: 1
```
Expand Down

0 comments on commit 07850ff

Please sign in to comment.