refactor(chip-set): correctly use MDC's HTML & classes #2683
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Kiarokh
force-pushed
the
chipset-refactor
branch
from
6ef4bed to
0fb102d
Compare
|
Documentation has been published to https://lundalogik.github.io/lime-elements/versions/PR-2683/ |
Kiarokh
force-pushed
the
chipset-refactor
branch
from
b8393bd to
7e8feed
Compare
LucyChyzhova
reviewed
Jan 4, 2024
| {this.renderLabel()} | ||
| <div class="mdc-notched-outline__trailing" /> | ||
| </div> | ||
| {this.renderLeadingIcon()} |
There was a problem hiding this comment.
This change causes the next issue 👇
Screen.Recording.2024-01-04.at.13.06.59.mov
We're inheriting styles from MDC, but since our HTML structure was not exactly similar to the one from MDC's input-field, and some classes were missing, then we had to make special styles to override what was coming from MDC, or to compensate for what was missing, due to missing classes.
Kiarokh
force-pushed
the
chipset-refactor
branch
from
7e8feed to
4e2c5d5
Compare
|
we need to come back to this after we have:
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
required for https://github.com/Lundalogik/crm-feature/issues/2723
We're inheriting styles from MDC, but since our HTML structure was not exactly similar to the one from
MDC's input-field, and some classes were missing,
then we had to make special styles to override what was coming from MDC, or to compensate for
what was missing, due to missing classes.
Review:
Browsers tested:
(Check any that applies, it's ok to leave boxes unchecked if testing something didn't seem relevant.)
Windows:
Linux:
macOS:
Mobile: