Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update todo.ejs #238

Open
wants to merge 8 commits into
base: master
Choose a base branch
from
Open

Update todo.ejs #238

Changes from 1 commit
Commits
Show all changes
8 commits
Select commit Hold shift + click to select a range
b0fffbd
Update todo.ejs
umashankar1987 Nov 15, 2024
219a41c
Update todo.ejs
umashankar1987 Nov 15, 2024
87cc01f
Merge pull request #1 from umashankar1987/umashankar1987-patch-1
umashankar1987 Nov 15, 2024
e180bf8
Update todo.ejs
umashankar1987 Nov 15, 2024
17eb5ed
Merge pull request #2 from umashankar1987/umashankar1987-master
umashankar1987 Nov 15, 2024
0814aae
Update todo.ejs
umashankar1987 Nov 15, 2024
47c5494
Update todo.ejs
umashankar1987 Nov 15, 2024
0192cef
Merge pull request #3 from umashankar1987/master-1
umashankar1987 Nov 15, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion views/todo.ejs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -89,7 +89,7 @@
</head>

<body>
<h1>Hello Junoon Batch 8 (Jenkins), Write your plan on Learning Jenkins</h1>
<h1>Hello Junoon Batch 8 (Jenkins), welcome journey of Learning Jenkins</h1>
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🧹 Nitpick (assertive)

Grammar needs improvement in the welcome message

The current heading text "welcome journey of Learning Jenkins" has grammatical issues. Consider these alternatives:

  • "Welcome to your Jenkins Learning Journey"
  • "Welcome to the Journey of Learning Jenkins"
-        <h1>Hello Junoon Batch 8 (Jenkins), welcome journey of Learning Jenkins</h1>
+        <h1>Hello Junoon Batch 8 (Jenkins), Welcome to your Jenkins Learning Journey</h1>
📝 Committable suggestion

‼️ IMPORTANT
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation. Thoroughly test & benchmark the code to ensure it meets the requirements.

Suggested change
<h1>Hello Junoon Batch 8 (Jenkins), welcome journey of Learning Jenkins</h1>
<h1>Hello Junoon Batch 8 (Jenkins), Welcome to your Jenkins Learning Journey</h1>

<ul>
<% todolist.forEach(function(todo, index) { %>
<li>
Expand Down