Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added Gutenberg Like Color Picking #51

Open
wants to merge 6 commits into
base: master
Choose a base branch
from

Conversation

ElvarP
Copy link

@ElvarP ElvarP commented Feb 25, 2023

Changed it so the color selection is more like the default Gutenberg color selection

image

image

@Log1x
Copy link
Owner

Log1x commented Feb 25, 2023

This is great! Will test ASAP.

@Log1x
Copy link
Owner

Log1x commented Feb 27, 2023

Screenshot

Getting broken styles on my end. Will figure out why later if you don't get to it first.

@Log1x
Copy link
Owner

Log1x commented Feb 27, 2023

Ah I see, the <ul> tag wasn't being closed.

Screenshot

I'd like to try to get even closer to Gutenberg's styling if possible. We can add the Theme text as well as work on the padding/margin between colors/on the container.

After that, maybe see about getting it to float to the left like the Gutenberg one does (although this might be unlikely). Til then, maybe some margin between the select box and the palette?

@ElvarP
Copy link
Author

ElvarP commented Feb 27, 2023

I'm really new to git and making pull requests btw so maybe Im doing something wrong...

I updated the styles to look a little bit more like Gutenberg as you requested, added the theme text and changed paddings/margins but I could not find a solution to make it hover to the left, had some z-index/overflow-hidden issues.

@Log1x
Copy link
Owner

Log1x commented Feb 27, 2023

I'm really new to git and making pull requests btw so maybe Im doing something wrong...

You're doing great. I really appreciate the contribution :)

I updated the styles to look a little bit more like Gutenberg as you requested,

Will check this out ASAP

but I could not find a solution to make it hover to the left, had some z-index/overflow-hidden issues.

I kinda figured this after I mentioned it.

@Log1x Log1x self-assigned this Feb 27, 2023
@Log1x Log1x added the enhancement New feature or request label Feb 27, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants