-
Notifications
You must be signed in to change notification settings - Fork 8
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added flock test. #315
Added flock test. #315
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The test makes sense as it tests the different types of locks on the fd. Other than what Kuzey already pointed out, looks good to me.
Yeah the test makes perfect sense in checking acquiring/releasing the lock. I don't know if we need to spawn another process to check the effectiveness of the lock. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this is ready to merge after my picky review
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great!
* add gunicorn py files (#269) Co-authored-by: lind <lind@nyu.edu> * epoll test and textfile (#274) * just the test and text file * with .py and slight change to test * fixing .py error Co-authored-by: lind <lind@nyu.edu> * add fchmod test to test suite (#275) * add fchmod test to test suite * fixing error message Co-authored-by: lind <lind@nyu.edu> * Fix Implicit Declarations warning in tests/test_cases/pread_pwrite.c (#282) * Add test cases for truncate and ftruncate (#283) * Add test case for truncate and ftruncate * Fix grammar mistake in error message * Update dettests.txt * Add fflush(NULL) after every print statement * Add a separate testfile for truncate.c * Add individual testfiles for different test cases * Fix pipepong.c and Add mutex.c (#286) * Fix pipepong.c and Add mutex.c * Fix indentation * Socketpair test (#290) * socketpair test * Added socketpair test in to dettests Co-authored-by: lind <lind@nyu.edu> * LAMP Scripts (#292) * setuptools * init * add setup tools * reorg * reorg * pr fix --------- Co-authored-by: lind <lind@nyu.edu> * Nacldesc scripts (#289) * update scripts * update scripts * Remove random prints from template.py and forkandopen.py (#295) * Net shutdown test case (#294) * [WIP]Setup threading and sockets * Incorrect version(passes in lind) * Add shutdown in fork test case * Add more comments * Add more comments and update nondet.txt * Add 1sec delay for synchronization and more verbose error messages * Use pthread barrier to sync up client and server in shutdown, socketselect, and socketepoll * Destroy closebarriers and add correctness checking in shutdown.py * small fix to epoll (#297) Co-authored-by: lind <lind@nyu.edu> * LAMP application and load scripts (#299) * add flask app and config files * Delete nginx.conf.backup --------- Co-authored-by: lind <lind@nyu.edu> * Simple web example (#300) * libffi bootstrap * Pared down webpage, trying to set up python to get ctypes working * Made ctypes compile properly --------- Co-authored-by: lind <lind@nyu.edu> * Fixed #301 libfii ctypes segfaulting (#304) * fixed #301 libfii ctypes segfaulting Signed-off-by: lind <lind@nyu.edu> * fix #301: update comments and load_python.sh Signed-off-by: lind <lind@nyu.edu> --------- Signed-off-by: lind <lind@nyu.edu> Co-authored-by: lind <lind@nyu.edu> * tests: IPC performance benchmark (#305) * tests: add IPC performance benchmark tests * tests: compilation scripts for IPC performance tests Signed-off-by: lind <lind@nyu.edu> * tests: userpipe test src files and compilation for IPC performance tests Signed-off-by: lind <lind@nyu.edu> --------- Signed-off-by: lind <lind@nyu.edu> * create pull_request_template.md (#309) * Tests of statfs/fstatfs (#312) * Add statfs test * Add fstatfs test * Statfs test file * fstatfs test file * Add to test suite * Update filepath * Update filename * Update * Update * Add new line * Add new line * Add check * Change to dettests * Make statfs/fstatfs work in test suite * Update typo * Update typo * Add new line and remove extra space * Refine format * Test files for mknod/fchdir/poll (#313) * Added Mknod, Fchdir and Poll Tests * Auto Test Done * Update fchdir.c Updated else clauses * Update dettests.txt * Update mknod.c * Update fchdir.c * Update poll.c * Update fchdir.c * Update fchdir.py * Delete mknod.c * Update dettests.txt * Update dettests.txt --------- Co-authored-by: lind <lind@nyu.edu> * Feature/new syscall tests cases (#306) * Implementd test for pipe2 syscall. * Implemented test for getifaddrs syscall. * Implemented test for getppid syscall. * Implemented test for mkdir and rmdir syscalls. * Implemented test for access syscall. * Updated getppid test to verify that pids match. * Renamed access test; changed print string. * Moved file name in creat_access test to #define clause. * Renamed rmdir test to mkdir_rmdir; moved dir name to #define clause. * Updated dettests.txt * Added pipe2.py to check pipe2 test output; updated nondet.txt * Added python script to verify getifaddrs; updated nondet.txt * Updated pipe2 output checking; added missing newlines at the end of test files. * Added newline characters at the end of files. * Added fflush after printfs. * Added fflushes. * Add include * Added flock test. (#315) * Added flock test. * Updated the flock test case to verify concurrent shared lock acquisition. * Added newline at end of file. * Fix Compilation Warning for flock.c * Update flock.c * fix: load libffi.so.5 in load_python.sh (#324) Signed-off-by: RusherRG <rushang101@gmail.com> * Add Shared memory and semaphore tests (#323) * tests: add shared memory and semaphores tests Signed-off-by: RusherRG <rushang101@gmail.com> * tests: add shared sempahores with multiple cages test Signed-off-by: RusherRG <rushang101@gmail.com> * tests: add buffer detach and removalin shm sem tests Signed-off-by: RusherRG <rushang101@gmail.com> * tests: remove prints in shm sem tests Signed-off-by: RusherRG <rushang101@gmail.com> * tests: update sleeps in shm sem tests Signed-off-by: RusherRG <rushang101@gmail.com> * tests: fix exits Signed-off-by: RusherRG <rushang101@gmail.com> * tests: add semaphore fork tests Signed-off-by: RusherRG <rushang101@gmail.com> * tests: make shm_sem_fork_t a non-deterministic test Signed-off-by: RusherRG <rushang101@gmail.com> --------- Signed-off-by: RusherRG <rushang101@gmail.com> * tests: update regex in forkandopen.py (#325) Signed-off-by: RusherRG <rushang101@gmail.com> * Flask app fix (#330) * fix: flask myproject.py sample app Signed-off-by: RusherRG <rushang101@gmail.com> * chore: update run_lamp.sh Signed-off-by: RusherRG <rushang101@gmail.com> --------- Signed-off-by: RusherRG <rushang101@gmail.com> * Add vscode instruction images (#334) * feat: add fast option to build rustposix in mklind (#335) Signed-off-by: lind <lind@nyu.edu> * Adding fdatasync test files and fixing flock warning (#338) Co-authored-by: lind <lind@nyu.edu> * Test files for sync_file_range (#340) * Adding fdatasync test files and fixing flock warning * Adding sync_file_range * Update dettests.txt * Update sync_file_range.c * Update sync_file_range.c * Update sync_file_range.c * Update sync_file_range.c --------- Co-authored-by: lind <lind@nyu.edu> * signal tests (#332) Co-authored-by: lind <lind@nyu.edu> * Uds tests (#333) * tests: uds test files Signed-off-by: RusherRG <rushang101@gmail.com> * tests: uds tests update Signed-off-by: RusherRG <rushang101@gmail.com> * chore: update mklind script Signed-off-by: RusherRG <rushang101@gmail.com> --------- Signed-off-by: RusherRG <rushang101@gmail.com> Co-authored-by: Nicholas Renner <nicholassrenner@gmail.com> * Add signal handling implementation document (#351) --------- Signed-off-by: lind <lind@nyu.edu> Signed-off-by: RusherRG <rushang101@gmail.com> Co-authored-by: lind <lind@nyu.edu> Co-authored-by: Justin Koe <100324413+justyoyo123@users.noreply.github.com> Co-authored-by: Tian(Maxwell) Yang <31149339+AlpacaMax@users.noreply.github.com> Co-authored-by: jesings <34111484+jesings@users.noreply.github.com> Co-authored-by: Devansh Patel <45604637+Devansh-Patel@users.noreply.github.com> Co-authored-by: Rushang Gajjal <rushang101@gmail.com> Co-authored-by: Y. W <40227173+Yaxuan-w@users.noreply.github.com> Co-authored-by: kuzeyardabulut <54737933+kuzeyardabulut@users.noreply.github.com> Co-authored-by: Keyur Panchal <keyur.panchal@gmail.com> Co-authored-by: Yaxuan-w <wenyaxuan0925@outlook.com> Co-authored-by: Mayank Ramnani <mayank-ramnani@users.noreply.github.com>
* Added flock test. * Updated the flock test case to verify concurrent shared lock acquisition. * Added newline at end of file.
* add gunicorn py files (#269) Co-authored-by: lind <lind@nyu.edu> * epoll test and textfile (#274) * just the test and text file * with .py and slight change to test * fixing .py error Co-authored-by: lind <lind@nyu.edu> * add fchmod test to test suite (#275) * add fchmod test to test suite * fixing error message Co-authored-by: lind <lind@nyu.edu> * Add test cases for truncate and ftruncate (#283) * Add test case for truncate and ftruncate * Fix grammar mistake in error message * Update dettests.txt * Add fflush(NULL) after every print statement * Add a separate testfile for truncate.c * Add individual testfiles for different test cases * Fix pipepong.c and Add mutex.c (#286) * Fix pipepong.c and Add mutex.c * Fix indentation * Socketpair test (#290) * socketpair test * Added socketpair test in to dettests Co-authored-by: lind <lind@nyu.edu> * LAMP Scripts (#292) * setuptools * init * add setup tools * reorg * reorg * pr fix --------- Co-authored-by: lind <lind@nyu.edu> * Remove random prints from template.py and forkandopen.py (#295) * Net shutdown test case (#294) * [WIP]Setup threading and sockets * Incorrect version(passes in lind) * Add shutdown in fork test case * Add more comments * Add more comments and update nondet.txt * Add 1sec delay for synchronization and more verbose error messages * Use pthread barrier to sync up client and server in shutdown, socketselect, and socketepoll * Destroy closebarriers and add correctness checking in shutdown.py * small fix to epoll (#297) Co-authored-by: lind <lind@nyu.edu> * LAMP application and load scripts (#299) * add flask app and config files * Delete nginx.conf.backup --------- Co-authored-by: lind <lind@nyu.edu> * Simple web example (#300) * libffi bootstrap * Pared down webpage, trying to set up python to get ctypes working * Made ctypes compile properly --------- Co-authored-by: lind <lind@nyu.edu> * Fixed #301 libfii ctypes segfaulting (#304) * fixed #301 libfii ctypes segfaulting Signed-off-by: lind <lind@nyu.edu> * fix #301: update comments and load_python.sh Signed-off-by: lind <lind@nyu.edu> --------- Signed-off-by: lind <lind@nyu.edu> Co-authored-by: lind <lind@nyu.edu> * Tests of statfs/fstatfs (#312) * Add statfs test * Add fstatfs test * Statfs test file * fstatfs test file * Add to test suite * Update filepath * Update filename * Update * Update * Add new line * Add new line * Add check * Change to dettests * Make statfs/fstatfs work in test suite * Update typo * Update typo * Add new line and remove extra space * Refine format * Test files for mknod/fchdir/poll (#313) * Added Mknod, Fchdir and Poll Tests * Auto Test Done * Update fchdir.c Updated else clauses * Update dettests.txt * Update mknod.c * Update fchdir.c * Update poll.c * Update fchdir.c * Update fchdir.py * Delete mknod.c * Update dettests.txt * Update dettests.txt --------- Co-authored-by: lind <lind@nyu.edu> * Feature/new syscall tests cases (#306) * Implementd test for pipe2 syscall. * Implemented test for getifaddrs syscall. * Implemented test for getppid syscall. * Implemented test for mkdir and rmdir syscalls. * Implemented test for access syscall. * Updated getppid test to verify that pids match. * Renamed access test; changed print string. * Moved file name in creat_access test to #define clause. * Renamed rmdir test to mkdir_rmdir; moved dir name to #define clause. * Updated dettests.txt * Added pipe2.py to check pipe2 test output; updated nondet.txt * Added python script to verify getifaddrs; updated nondet.txt * Updated pipe2 output checking; added missing newlines at the end of test files. * Added newline characters at the end of files. * Added fflush after printfs. * Added fflushes. * Add include * Added flock test. (#315) * Added flock test. * Updated the flock test case to verify concurrent shared lock acquisition. * Added newline at end of file. * Fix Compilation Warning for flock.c * Update flock.c * fix: load libffi.so.5 in load_python.sh (#324) Signed-off-by: RusherRG <rushang101@gmail.com> * Add Shared memory and semaphore tests (#323) * tests: add shared memory and semaphores tests Signed-off-by: RusherRG <rushang101@gmail.com> * tests: add shared sempahores with multiple cages test Signed-off-by: RusherRG <rushang101@gmail.com> * tests: add buffer detach and removalin shm sem tests Signed-off-by: RusherRG <rushang101@gmail.com> * tests: remove prints in shm sem tests Signed-off-by: RusherRG <rushang101@gmail.com> * tests: update sleeps in shm sem tests Signed-off-by: RusherRG <rushang101@gmail.com> * tests: fix exits Signed-off-by: RusherRG <rushang101@gmail.com> * tests: add semaphore fork tests Signed-off-by: RusherRG <rushang101@gmail.com> * tests: make shm_sem_fork_t a non-deterministic test Signed-off-by: RusherRG <rushang101@gmail.com> --------- Signed-off-by: RusherRG <rushang101@gmail.com> * tests: update regex in forkandopen.py (#325) Signed-off-by: RusherRG <rushang101@gmail.com> * Flask app fix (#330) * fix: flask myproject.py sample app Signed-off-by: RusherRG <rushang101@gmail.com> * chore: update run_lamp.sh Signed-off-by: RusherRG <rushang101@gmail.com> --------- Signed-off-by: RusherRG <rushang101@gmail.com> * Adding fdatasync test files and fixing flock warning (#338) Co-authored-by: lind <lind@nyu.edu> * Test files for sync_file_range (#340) * Adding fdatasync test files and fixing flock warning * Adding sync_file_range * Update dettests.txt * Update sync_file_range.c * Update sync_file_range.c * Update sync_file_range.c * Update sync_file_range.c --------- Co-authored-by: lind <lind@nyu.edu> * signal tests (#332) Co-authored-by: lind <lind@nyu.edu> * Uds tests (#333) * tests: uds test files Signed-off-by: RusherRG <rushang101@gmail.com> * tests: uds tests update Signed-off-by: RusherRG <rushang101@gmail.com> * chore: update mklind script Signed-off-by: RusherRG <rushang101@gmail.com> --------- Signed-off-by: RusherRG <rushang101@gmail.com> Co-authored-by: Nicholas Renner <nicholassrenner@gmail.com> * tests: add IPC performance tests (#353) * tests: formatting ipc_performance tests Signed-off-by: RusherRG <rushang101@gmail.com> * tests: add optimization to ipc performance tests Signed-off-by: lind <lind@nyu.edu> * tests: update ipc performance test compile scripts Signed-off-by: lind <lind@nyu.edu> * tests: add buffer read write tests Signed-off-by: lind <lind@nyu.edu> * tests: add timers to buffer_read_write Signed-off-by: lind <lind@nyu.edu> * tests: update buffer read write scripts Signed-off-by: lind <lind@nyu.edu> * graphs * graphs * graphs * graphs * graphs * tests: add buffer_read_write times Signed-off-by: lind <lind@nyu.edu> * feat: add ping/pong inet test scripts Signed-off-by: lind <lind@nyu.edu> * feat: update ping/pong inet test scripts Signed-off-by: lind <lind@nyu.edu> * test: remove flamegraphs from buffer_read_write Signed-off-by: lind <lind@nyu.edu> * test: remove perf files from inet Signed-off-by: lind <lind@nyu.edu> * test: update syscall_ratios with plotting scripts Signed-off-by: lind <lind@nyu.edu> * test: update total_runtime with plotting scripts Signed-off-by: lind <lind@nyu.edu> * test: update buffer_read_write formatting Signed-off-by: lind <lind@nyu.edu> * test: update total_runtime formatting Signed-off-by: lind <lind@nyu.edu> * test: add README.md in buffer_read_write Signed-off-by: lind <lind@nyu.edu> * test: add README.md in inet Signed-off-by: lind <lind@nyu.edu> * test: add README.md for all the tests in ipc_performance_tests Signed-off-by: lind <lind@nyu.edu> * tests: remove target/ from ipc_performance_tests/total_runtime/scripts/userpipe Signed-off-by: lind <lind@nyu.edu> * tests: remove graphs Signed-off-by: lind <lind@nyu.edu> * tests: remove data output files from ipc performance tests Signed-off-by: lind <lind@nyu.edu> --------- Signed-off-by: RusherRG <rushang101@gmail.com> Signed-off-by: lind <lind@nyu.edu> Co-authored-by: lind <lind@nyu.edu> * tests: unix bash pipelines (#354) * tests: bash pipeline scripts Signed-off-by: RusherRG <rushang101@gmail.com> * grep perf data Signed-off-by: RusherRG <rushang101@gmail.com> * tests: chain of cats benchmark Signed-off-by: RusherRG <rushang101@gmail.com> * tests: add scripts to benchmark coreutils pipelines on native and lind Signed-off-by: RusherRG <rushang101@gmail.com> * update Signed-off-by: RusherRG <rushang101@gmail.com> * tests: pipeline_tests cleanup Signed-off-by: RusherRG <rushang101@gmail.com> * tests: reorganize pipeline-tests Signed-off-by: RusherRG <rushang101@gmail.com> * tests: change extension of scripts Signed-off-by: lind <lind@nyu.edu> * tests: update pipeline_tests scripts Signed-off-by: lind <lind@nyu.edu> * tests: remove unnecessary files Signed-off-by: lind <lind@nyu.edu> * tests: update cat_bench.py Signed-off-by: lind <lind@nyu.edu> * tests: add README.md Signed-off-by: lind <lind@nyu.edu> * tests: add plotting scripts to pipeline_tests Signed-off-by: lind <lind@nyu.edu> --------- Signed-off-by: RusherRG <rushang101@gmail.com> Signed-off-by: lind <lind@nyu.edu> * tests: lamp stack (#356) * tests: lamp stack pgbench tests Signed-off-by: RusherRG <rushang101@gmail.com> * tests: lamp stack profiling Signed-off-by: RusherRG <rushang101@gmail.com> * tests: update lamp stack scripts Signed-off-by: RusherRG <rushang101@gmail.com> * tests: fix lamp stack postgres queries Signed-off-by: RusherRG <rushang101@gmail.com> * tests: chmod for lamp stack scripts Signed-off-by: RusherRG <rushang101@gmail.com> * tests: lamp stack remove create.html Signed-off-by: RusherRG <rushang101@gmail.com> * tests: native lamp stack updates Signed-off-by: RusherRG <rushang101@gmail.com> * tests: make scripts executable Signed-off-by: RusherRG <rushang101@gmail.com> * tests: add prints to pgbench run Signed-off-by: RusherRG <rushang101@gmail.com> * tests: fixing lamp-stack tests and update sleep times Signed-off-by: lind <lind@nyu.edu> * tests: update nginx configuration Signed-off-by: lind <lind@nyu.edu> * tests: reformatting lamp stack tests Signed-off-by: lind <lind@nyu.edu> * tests: reformatting lamp stack tests Signed-off-by: lind <lind@nyu.edu> * tests: adding -O3 flag to postgres bootstrap_nacl Signed-off-by: lind <lind@nyu.edu> * tests: adding scripts for no postgres versions Signed-off-by: lind <lind@nyu.edu> * tests: update pgbench and profiling scripts Signed-off-by: lind <lind@nyu.edu> * tests: add no-flask test scripts Signed-off-by: lind <lind@nyu.edu> * tests: update no-flask test times Signed-off-by: lind <lind@nyu.edu> * tests: update flask app to restructure the data generation Signed-off-by: lind <lind@nyu.edu> * fix: nginx platform word size Signed-off-by: lind <lind@nyu.edu> * fix: use unix sockets for gunicorn Signed-off-by: lind <lind@nyu.edu> * feat: update pgbench scripts Signed-off-by: lind <lind@nyu.edu> * feat: add nginx only scripts Signed-off-by: lind <lind@nyu.edu> * feat: update lamp_stack scripts and files Signed-off-by: lind <lind@nyu.edu> * test: add scripts about select_accept Signed-off-by: lind <lind@nyu.edu> * tests: refactor pgbench tests Signed-off-by: lind <lind@nyu.edu> * tests: refactor profiling tests Signed-off-by: lind <lind@nyu.edu> * tests: refactor profiling select_accpet tests Signed-off-by: lind <lind@nyu.edu> * tests: update nginx scripts Signed-off-by: lind <lind@nyu.edu> * tests: add README.md and compile.sh to profiling Signed-off-by: lind <lind@nyu.edu> --------- Signed-off-by: RusherRG <rushang101@gmail.com> Signed-off-by: lind <lind@nyu.edu> * tests: Unix domain sockets (#355) * tests: formatting ipc_performance tests Signed-off-by: RusherRG <rushang101@gmail.com> * uds ipc test and scripts * removing prints * push * tests: reorganize uds ipc tests Signed-off-by: RusherRG <rushang101@gmail.com> * tests: update uds ipc tests to support more than 1GB data Signed-off-by: RusherRG <rushang101@gmail.com> * tests: uds native test str(total_size) Signed-off-by: RusherRG <rushang101@gmail.com> * tests: uds plot scripts Signed-off-by: RusherRG <rushang101@gmail.com> * tests: update uds ipc test Signed-off-by: RusherRG <rushang101@gmail.com> * tests: adding -O3 to uds tests Signed-off-by: lind <lind@nyu.edu> * tests: updating uds script to uds_send_recv Signed-off-by: lind <lind@nyu.edu> * chore: remove unnecessary files Signed-off-by: lind <lind@nyu.edu> * tests: cleanup uds tests Signed-off-by: lind <lind@nyu.edu> * tests: add README.md and plot scripts in uds Signed-off-by: lind <lind@nyu.edu> * tests: remove data output files from uds Signed-off-by: lind <lind@nyu.edu> --------- Signed-off-by: RusherRG <rushang101@gmail.com> Signed-off-by: lind <lind@nyu.edu> Co-authored-by: lind <lind@nyu.edu> * Fix UDS tests after signal merge (#357) * updating submodules to latest commits for Merge into main --------- Signed-off-by: lind <lind@nyu.edu> Signed-off-by: RusherRG <rushang101@gmail.com> Co-authored-by: lind <lind@nyu.edu> Co-authored-by: Justin Koe <100324413+justyoyo123@users.noreply.github.com> Co-authored-by: Tian(Maxwell) Yang <31149339+AlpacaMax@users.noreply.github.com> Co-authored-by: jesings <34111484+jesings@users.noreply.github.com> Co-authored-by: Devansh Patel <45604637+Devansh-Patel@users.noreply.github.com> Co-authored-by: Rushang Gajjal <rushang101@gmail.com> Co-authored-by: Y. W <40227173+Yaxuan-w@users.noreply.github.com> Co-authored-by: kuzeyardabulut <54737933+kuzeyardabulut@users.noreply.github.com> Co-authored-by: Keyur Panchal <keyur.panchal@gmail.com> Co-authored-by: Yaxuan-w <wenyaxuan0925@outlook.com> Co-authored-by: Mayank Ramnani <mayank-ramnani@users.noreply.github.com> Co-authored-by: Yashaswi Makula <yashaswi.makula@gmail.com>
Description
This change adds a test for the
flock
syscall. It has also been added to the list of deterministic test cases indettests.txt
While working on this test, two issues were found regarding the
flock
. PRs to fix both have been raised in their respective repositories.Both of them should be merged before merging this one.
Type of change
How Has This Been Tested?
After making the changes associated with the aforementioned PRs,
make test-verbose
was run to ensureChecklist: