Fix `ut_lind_fs_mkdir_invalid_modebits` #43

ChinmayShringi · 2024-09-28T18:51:58Z

Fixes # (issue)

This update modifies mkdir_syscall to properly handle and reject invalid mode bits when creating a directory. If the mode includes bits outside the valid range (0o0000 to 0o0777), the syscall now returns an EPERM error, indicating that the permission bits are not valid. This change ensures consistent behavior in accordance with POSIX standards, preventing directories from being created with unsupported or incorrect permissions.

Type of change

Bug fix (non-breaking change which fixes an issue)

How Has This Been Tested?

cargo test ut_lind_fs_mkdir_invalid_modebits

Checklist:

My code follows the style guidelines of this project
I have commented my code, particularly in hard-to-understand areas
My changes generate no new warnings
I have added tests that prove my fix is effective or that my feature works
Any dependent changes have been added to a pull request and/or merged in other modules (native-client, lind-glibc, lind-project)

…t case (#16) * fix: ut_lind_fs_chdir_removeddir * fix: add syscalls * fix: revert changes * fix: testing subdir1 * fix: testing without i32 * fix: revert to mkdir * fix: test with if * fix: revert * debug: added print * debug: added print * fix: print * fix: revert println * feat: return invalid * fix: revert removed return * feat: update rm subdir1 subdir2 * refactor: update comments

…d-args Fix invalid file descriptor handling and unlink file in fchdir syscall tests

* Fix: out-of-range file descriptor handling in getdents syscall * fix: update comment * Update src/fdtables/dashmapvecglobal.rs Co-authored-by: Justin Cappos <justincappos@gmail.com> --------- Co-authored-by: lind <lind@nyu.edu> Co-authored-by: Justin Cappos <justincappos@gmail.com>

…rrno` (#24) * fix: test case ut_lind_fs_getcwd_invalid_args * fix: PR comments --------- Co-authored-by: lind <lind@nyu.edu>

* Fix: mmap test to validate EINVAL for invalid flags * fix: PR comments --------- Co-authored-by: lind <lind@nyu.edu>

…orrect Error (#27) * fix: test case ut_lind_fs_pread_from_directory * fix: add rmdir syscall --------- Co-authored-by: lind <lind@nyu.edu>

Co-authored-by: lind <lind@nyu.edu>

…n Handling and Recursive Directory Cleanup (#28) * fix: test case ut_lind_fs_rmdir_nowriteperm_parent_dir * feat: added cleanup --------- Co-authored-by: lind <lind@nyu.edu>

* fix: test case ut_lind_fs_mkdir_nonexisting_directory * feat: added rmdir_recursive_syscall * fix: rm unecessary function * feat: updated comment * feat: updated values --------- Co-authored-by: lind <lind@nyu.edu>

…djusting Directory Open Flags (#29) * fix: test case ut_lind_fs_getdents_bufsize_too_small * fix: rmdir for clean env --------- Co-authored-by: lind <lind@nyu.edu>

…sting Directories Before Creation (#31) * fix: test case ut_lind_fs_close_directory * feat: use rmdir --------- Co-authored-by: lind <lind@nyu.edu>

…ng Directories Before Creation (#32) * fix: test case ut_lind_fs_dir_multiple * feat: updated to rmdir --------- Co-authored-by: lind <lind@nyu.edu>

…irectories Before Creation (#30) * fix: test case ut_lind_fs_dir_mode * fix: cleanup the enviornment --------- Co-authored-by: lind <lind@nyu.edu>

…et Up and Cleaned (#35)

Yaxuan-w · 2024-09-29T17:03:32Z

src/safeposix/syscalls/fs_calls.rs

+        if (mode & !0o777) != 0 {
+            return syscall_error(Errno::EPERM, "mkdir", "Invalid mode bits specified");
+        }


what is currently rawposix returned in this situation?

Currently it return a -1 value

Could you test with get_errno() to see the errno returned by libc::mmap?

Sth like:

let ret = libc::mmap(...) if ret < 0 { println!(get_errno()); }

This case should be handled in rust libc as well... So we don't need those checks

commit e44f2c0 Author: Alice Wen <40227173+Yaxuan-w@users.noreply.github.com> Date: Tue Oct 8 14:58:46 2024 -0400 Update README.md commit e244b91 Author: Chinmay Shringi <31031919+ChinmayShringi@users.noreply.github.com> Date: Tue Oct 8 14:55:53 2024 -0400 Feat update readme (#49) * feat: update readme * feat: added images commit ebff6b7 Author: Alice Wen <40227173+Yaxuan-w@users.noreply.github.com> Date: Tue Oct 1 13:21:00 2024 -0400 Porting newest version fdtables and Synchronize the progress of porting test suite (#14) * change to latest fdtables * using newest fdtables * mmap debug * mmap debug * mmap debug * porting test suite * porting test suite * Add more detailed comments * Fix directory cleanup issue in ut_lind_fs_mmap_invalid_flags_both test case (#16) * fix: ut_lind_fs_chdir_removeddir * fix: add syscalls * fix: revert changes * fix: testing subdir1 * fix: testing without i32 * fix: revert to mkdir * fix: test with if * fix: revert * debug: added print * debug: added print * fix: print * fix: revert println * feat: return invalid * fix: revert removed return * feat: update rm subdir1 subdir2 * refactor: update comments * fix: test case ut-lind-fs-fchdir-invalid-args * Fix out-of-range file descriptor error in `getdents` syscall (#17) * Fix: out-of-range file descriptor handling in getdents syscall * fix: update comment * Update src/fdtables/dashmapvecglobal.rs Co-authored-by: Justin Cappos <justincappos@gmail.com> --------- Co-authored-by: lind <lind@nyu.edu> Co-authored-by: Justin Cappos <justincappos@gmail.com> * Fix `getcwd_syscall` to Handle Invalid Arguments and Correctly Set `errno` (#24) * fix: test case ut_lind_fs_getcwd_invalid_args * fix: PR comments --------- Co-authored-by: lind <lind@nyu.edu> * Fix mmap test case to handle invalid flags scenario correctly (#18) * Fix: mmap test to validate EINVAL for invalid flags * fix: PR comments --------- Co-authored-by: lind <lind@nyu.edu> * Fix Test `ut_lind_fs_pread_from_directory` from Directory to Return Correct Error (#27) * fix: test case ut_lind_fs_pread_from_directory * fix: add rmdir syscall --------- Co-authored-by: lind <lind@nyu.edu> * fix: test case ut-lind-fs-write-to-directory (#19) Co-authored-by: lind <lind@nyu.edu> * fix: ut-lind-fs-simple (#21) Co-authored-by: lind <lind@nyu.edu> * Fix `ut_lind_fs_rmdir_nowriteperm_parent_dir` rmdir Nowrite Permission Handling and Recursive Directory Cleanup (#28) * fix: test case ut_lind_fs_rmdir_nowriteperm_parent_dir * feat: added cleanup --------- Co-authored-by: lind <lind@nyu.edu> * Fix ut lind fs mkdir nonexisting directory (#25) * fix: test case ut_lind_fs_mkdir_nonexisting_directory * feat: added rmdir_recursive_syscall * fix: rm unecessary function * feat: updated comment * feat: updated values --------- Co-authored-by: lind <lind@nyu.edu> * Fix EISDIR Error in `ut_lind_fs_getdents_bufsize_too_small` Test by Adjusting Directory Open Flags (#29) * fix: test case ut_lind_fs_getdents_bufsize_too_small * fix: rmdir for clean env --------- Co-authored-by: lind <lind@nyu.edu> * Fix EEXIST Error in `ut_lind_fs_close_directory` Test by Removing Existing Directories Before Creation (#31) * fix: test case ut_lind_fs_close_directory * feat: use rmdir --------- Co-authored-by: lind <lind@nyu.edu> * Fix EEXIST Error in `ut_lind_fs_dir_multiple` Test by Removing Existing Directories Before Creation (#32) * fix: test case ut_lind_fs_dir_multiple * feat: updated to rmdir --------- Co-authored-by: lind <lind@nyu.edu> * Fix EEXIST Error in `ut_lind_fs_dir_mode` Test by Removing Existing Directories Before Creation (#30) * fix: test case ut_lind_fs_dir_mode * fix: cleanup the enviornment --------- Co-authored-by: lind <lind@nyu.edu> * Fix EEXIST Error in `ut_lind_fs_unlink_directory` (#34) * fix: test case ut_lind_fs_rmdir_nonexist_dir (#36) * fix: test case ut_lind_fs_rmdir_nonempty_dir (#37) * fix: test case ut_lind_fs_link_directory (#38) * fix: test case ut_lind_fs_read_from_directory (#39) * fix: test case ut_lind_fs_rename (#41) * Fix in `ut_lind_fs_tmp_file_test` ensure /tmp Directory Is Properly Set Up and Cleaned (#35) * fix: test case ut_lind_fs_read_from_chardev_file (#44) Co-authored-by: lind <lind@nyu.edu> --------- Co-authored-by: Chinmay Shringi <31031919+ChinmayShringi@users.noreply.github.com> Co-authored-by: lind <lind@nyu.edu> Co-authored-by: Nicholas Renner <nr2185@nyu.edu> Co-authored-by: Justin Cappos <justincappos@gmail.com>

Yaxuan-w

LGTM

Yaxuan-w

sry for the confusion

Yaxuan-w · 2024-10-09T14:06:51Z

src/safeposix/syscalls/fs_calls.rs

+        if (mode & !0o777) != 0 {
+            return syscall_error(Errno::EPERM, "mkdir", "Invalid mode bits specified");
+        }


This case should be handled in rust libc as well... So we don't need those checks

Yaxuan-w

lgtm

Yaxuan-w and others added 30 commits September 16, 2024 16:15

change to latest fdtables

8368098

using newest fdtables

11ad01e

mmap debug

36edba7

mmap debug

5c0279b

mmap debug

5dd1db2

porting test suite

563f581

porting test suite

80d87b8

Add more detailed comments

323c394

fix: test case ut-lind-fs-fchdir-invalid-args

f80e5b1

Merge pull request #23 from Lind-Project/fix-ut-lind-fs-fchdir-invali…

7da2f39

…d-args Fix invalid file descriptor handling and unlink file in fchdir syscall tests

Fix getcwd_syscall to Handle Invalid Arguments and Correctly Set `e…

26e41f0

…rrno` (#24) * fix: test case ut_lind_fs_getcwd_invalid_args * fix: PR comments --------- Co-authored-by: lind <lind@nyu.edu>

Fix mmap test case to handle invalid flags scenario correctly (#18)

f284122

* Fix: mmap test to validate EINVAL for invalid flags * fix: PR comments --------- Co-authored-by: lind <lind@nyu.edu>

Fix Test ut_lind_fs_pread_from_directory from Directory to Return C…

e1fde15

…orrect Error (#27) * fix: test case ut_lind_fs_pread_from_directory * fix: add rmdir syscall --------- Co-authored-by: lind <lind@nyu.edu>

fix: test case ut-lind-fs-write-to-directory (#19)

c9f0ea0

Co-authored-by: lind <lind@nyu.edu>

fix: ut-lind-fs-simple (#21)

16771ea

Co-authored-by: lind <lind@nyu.edu>

Fix ut_lind_fs_rmdir_nowriteperm_parent_dir rmdir Nowrite Permissio…

395f8c6

…n Handling and Recursive Directory Cleanup (#28) * fix: test case ut_lind_fs_rmdir_nowriteperm_parent_dir * feat: added cleanup --------- Co-authored-by: lind <lind@nyu.edu>

Fix ut lind fs mkdir nonexisting directory (#25)

0169e4e

* fix: test case ut_lind_fs_mkdir_nonexisting_directory * feat: added rmdir_recursive_syscall * fix: rm unecessary function * feat: updated comment * feat: updated values --------- Co-authored-by: lind <lind@nyu.edu>

Fix EISDIR Error in ut_lind_fs_getdents_bufsize_too_small Test by A…

faeeafb

…djusting Directory Open Flags (#29) * fix: test case ut_lind_fs_getdents_bufsize_too_small * fix: rmdir for clean env --------- Co-authored-by: lind <lind@nyu.edu>

Fix EEXIST Error in ut_lind_fs_close_directory Test by Removing Exi…

197b681

…sting Directories Before Creation (#31) * fix: test case ut_lind_fs_close_directory * feat: use rmdir --------- Co-authored-by: lind <lind@nyu.edu>

Fix EEXIST Error in ut_lind_fs_dir_multiple Test by Removing Existi…

28a3346

…ng Directories Before Creation (#32) * fix: test case ut_lind_fs_dir_multiple * feat: updated to rmdir --------- Co-authored-by: lind <lind@nyu.edu>

Fix EEXIST Error in ut_lind_fs_dir_mode Test by Removing Existing D…

215463e

…irectories Before Creation (#30) * fix: test case ut_lind_fs_dir_mode * fix: cleanup the enviornment --------- Co-authored-by: lind <lind@nyu.edu>

Fix EEXIST Error in ut_lind_fs_unlink_directory (#34)

3cb39be

fix: test case ut_lind_fs_rmdir_nonexist_dir (#36)

f408200

fix: test case ut_lind_fs_rmdir_nonempty_dir (#37)

799a8a4

fix: test case ut_lind_fs_link_directory (#38)

b3cf1bb

fix: test case ut_lind_fs_read_from_directory (#39)

71d4129

fix: test case ut_lind_fs_rename (#41)

c245167

Fix in ut_lind_fs_tmp_file_test ensure /tmp Directory Is Properly S…

98fedea

…et Up and Cleaned (#35)

fix: test case ut_lind_fs_mkdir_invalid_modebits

4f91e9b

ChinmayShringi changed the base branch from main to porting-fdtables September 28, 2024 18:52

ChinmayShringi requested review from rennergade and Yaxuan-w September 28, 2024 18:52

Yaxuan-w reviewed Sep 29, 2024

View reviewed changes

ChinmayShringi changed the base branch from porting-fdtables to main October 8, 2024 19:26

Merge branch 'main' into fix-ut-lind-fs-mkdir-invalid-modebits

0b355f5

Yaxuan-w approved these changes Oct 9, 2024

View reviewed changes

Yaxuan-w requested changes Oct 9, 2024

View reviewed changes

feat: updated directory creation with libc::mkdir

a0f97d2

ChinmayShringi requested a review from Yaxuan-w October 22, 2024 20:08

Yaxuan-w approved these changes Oct 22, 2024

View reviewed changes

Yaxuan-w merged commit 45f5927 into main Oct 23, 2024
1 check failed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Fix `ut_lind_fs_mkdir_invalid_modebits` #43

Fix `ut_lind_fs_mkdir_invalid_modebits` #43

ChinmayShringi commented Sep 28, 2024

Yaxuan-w Sep 29, 2024

ChinmayShringi Sep 29, 2024

Yaxuan-w Sep 30, 2024

Yaxuan-w Oct 9, 2024

Yaxuan-w left a comment

Yaxuan-w left a comment

Yaxuan-w Oct 9, 2024

Yaxuan-w left a comment

Fix ut_lind_fs_mkdir_invalid_modebits #43

Fix ut_lind_fs_mkdir_invalid_modebits #43

Conversation

ChinmayShringi commented Sep 28, 2024

Type of change

How Has This Been Tested?

Checklist:

Yaxuan-w Sep 29, 2024

Choose a reason for hiding this comment

ChinmayShringi Sep 29, 2024

Choose a reason for hiding this comment

Yaxuan-w Sep 30, 2024

Choose a reason for hiding this comment

Yaxuan-w Oct 9, 2024

Choose a reason for hiding this comment

Yaxuan-w left a comment

Choose a reason for hiding this comment

Yaxuan-w left a comment

Choose a reason for hiding this comment

Yaxuan-w Oct 9, 2024

Choose a reason for hiding this comment

Yaxuan-w left a comment

Choose a reason for hiding this comment

Fix `ut_lind_fs_mkdir_invalid_modebits` #43

Fix `ut_lind_fs_mkdir_invalid_modebits` #43