Added check/error in PdfPTable.addCell #1195
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
asturio
requested changes
Aug 7, 2024
There was a problem hiding this comment.
Hi @StevenStreasick ,
could you take a look at these checkstyle errors and correct your PR?
Fixed workflow issues
|
asturio
added a commit
that referenced
this pull request
Nov 25, 2024
- Added Test for changed Method - Added localization for exception message
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of the new Feature/Bugfix
I added a custom error message to PdfPTable.addCell(PdfPTable table) if the user called addCell with itself as the parameter.
Related Issue: Previously, the error would grow in the terminal, which made it a nightmare to troubleshoot. The error was also not descriptive, makin it even harder to troubleshoot.
Unit-Tests for the new Feature/Bugfix
Compatibilities Issues
The PdfPTable.addCell method signature was changed - now it can throw a DocumentException, but no repository code should be impacted..
Your real name
Steven Streasick
Testing details