Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(oft-solana): don't create multisig if no additional minters #1170

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

feat(oft-solana): don't create multisig if no additional minters #1170

wants to merge 1 commit into from
+22 −16

Conversation

nazreen
Copy link
Contributor

@nazreen nazreen commented Jan 15, 2025 •
edited
Loading

To test:

LZ_ENABLE_SOLANA_OFT_EXAMPLE=1 LAYERZERO_EXAMPLES_REPOSITORY_REF=#nazreen/oft-solana/rm-unnecessary-multisig-creation npx create-lz-oapp@latest

Test results:

When: no additional minters, Mint Authority is OFT Store
Mint: https://solscan.io/account/LbLqBcGtLQ55X13XWM35FS1rG3v1kdH3amXa9MWqxqs?cluster=devnet
Multisig: not created
Successful cross chain transfers:

When: additional minters provided, Mint Authority is Multisig
Mint: https://solscan.io/token/2H1PMNrahdQjZMpXfv7fdaFyuQjnJXHh7yAwxRqe2Zvc?cluster=devnet
Multisig: https://solscan.io/account/6qM5aYWRuLg6PLmgrJE7bbrYuNoBPg6p6ZxDYHU2Mk8q?cluster=devnet
Successful cross chain transfers:

@nazreen nazreen marked this pull request as ready for review January 15, 2025 11:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@DanL0 DanL0 Awaiting requested review from DanL0

@ryandgoulding ryandgoulding Awaiting requested review from ryandgoulding

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@nazreen