-
Notifications
You must be signed in to change notification settings - Fork 174
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
🪲squads multisig set send receive libs #1150
Conversation
Signed-off-by: Ryan Goulding <goulding@layerzerolabs.org>
Signed-off-by: Ryan Goulding <goulding@layerzerolabs.org>
New dependencies detected. Learn more about Socket for GitHub ↗︎
|
🚨 Potential security issues detected. Learn more about Socket for GitHub ↗︎ To accept the risk, merge this PR and you will not be notified again.
Next stepsWhat are unpopular packages?This package is not very popular. Unpopular packages may have less maintenance and contain other problems. Take a deeper look at the dependencyTake a moment to review the security alert above. Review the linked package source code to understand the potential risk. Ensure the package is not malicious before proceeding. If you're unsure how to proceed, reach out to your security team or ask the Socket team for help at support [AT] socket [DOT] dev. Remove the packageIf you happen to install a dependency that Socket reports as Known Malware you should immediately remove it and select a different dependency. For other alert types, you may may wish to investigate alternative packages or consider if there are other ways to mitigate the specific risk posed by the dependency. Mark a package as acceptable riskTo ignore an alert, reply with a comment starting with
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 🚀
This change does the following:
protocol-devtools-solana
to rely on@layerzerolabs/oft-v2-solana-sdk
. This may seem non-intuitive, but the existing solitasetSendLibrary(...)
is broken. Essentially, it would always fail in a squads multisig use case as the provided signer would fail to be Authorized (it wasn't the oapp, nor the delegate). The updated implementation carefully takes care of this bug.protocol-devtools-solana
to targetes2020
, required to use BigInt nomenclature0n
.ua-devtools-solana
to use the appropriatedelegate
oradmin
, depending on the access control requirements. This is something that has been broken since day one.All of this was tested thoroughly on mainnet:
First, optimism was added. Then, arbitrum:
https://layerzeroscan.com/address/3CS8Q4k4TcCHn1E6cYvBD6HTAgDFg29zqdyaA7ih2jpW