Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🪲squads multisig set send receive libs #1150

Merged
merged 3 commits into from
Jan 7, 2025

Conversation

ryandgoulding
Copy link
Contributor

This change does the following:

  • removes actual unused methods in oft-devtools-solana. They were actual dead code.
  • changes protocol-devtools-solana to rely on @layerzerolabs/oft-v2-solana-sdk. This may seem non-intuitive, but the existing solita setSendLibrary(...) is broken. Essentially, it would always fail in a squads multisig use case as the provided signer would fail to be Authorized (it wasn't the oapp, nor the delegate). The updated implementation carefully takes care of this bug.
  • bumps protocol-devtools-solana to target es2020, required to use BigInt nomenclature 0n.
  • Changes ua-devtools-solana to use the appropriate delegate or admin, depending on the access control requirements. This is something that has been broken since day one.

All of this was tested thoroughly on mainnet:

First, optimism was added. Then, arbitrum:

https://layerzeroscan.com/address/3CS8Q4k4TcCHn1E6cYvBD6HTAgDFg29zqdyaA7ih2jpW

Signed-off-by: Ryan Goulding <goulding@layerzerolabs.org>
Signed-off-by: Ryan Goulding <goulding@layerzerolabs.org>
Signed-off-by: Ryan Goulding <goulding@layerzerolabs.org>
Copy link

New dependencies detected. Learn more about Socket for GitHub ↗︎

Package New capabilities Transitives Size Publisher
npm/@layerzerolabs/oft-v2-solana-sdk@3.0.38 Transitive: environment, eval, filesystem, network, shell, unsafe +232 88.6 MB layerzero-bot

View full report↗︎

Copy link

🚨 Potential security issues detected. Learn more about Socket for GitHub ↗︎

To accept the risk, merge this PR and you will not be notified again.

Alert Package NoteSourceCI
Unpopular package npm/@layerzerolabs/lz-serdes@3.0.38 ⚠︎
Unpopular package npm/@initia/initia.js@0.2.24 ⚠︎

View full report↗︎

Next steps

What are unpopular packages?

This package is not very popular.

Unpopular packages may have less maintenance and contain other problems.

Take a deeper look at the dependency

Take a moment to review the security alert above. Review the linked package source code to understand the potential risk. Ensure the package is not malicious before proceeding. If you're unsure how to proceed, reach out to your security team or ask the Socket team for help at support [AT] socket [DOT] dev.

Remove the package

If you happen to install a dependency that Socket reports as Known Malware you should immediately remove it and select a different dependency. For other alert types, you may may wish to investigate alternative packages or consider if there are other ways to mitigate the specific risk posed by the dependency.

Mark a package as acceptable risk

To ignore an alert, reply with a comment starting with @SocketSecurity ignore followed by a space separated list of ecosystem/package-name@version specifiers. e.g. @SocketSecurity ignore npm/foo@1.0.0 or ignore all packages with @SocketSecurity ignore-all

  • @SocketSecurity ignore npm/@layerzerolabs/lz-serdes@3.0.38
  • @SocketSecurity ignore npm/@initia/initia.js@0.2.24

Copy link
Contributor

@ravinagill15 ravinagill15 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🚀

packages/ua-devtools-solana/src/oft/sdk.ts Show resolved Hide resolved
@ryandgoulding ryandgoulding merged commit 51c4086 into main Jan 7, 2025
7 checks passed
@ryandgoulding ryandgoulding deleted the fix/squads_multisig_set_send_receive_libs branch January 7, 2025 01:14
ryandgoulding added a commit that referenced this pull request Jan 7, 2025
…ersion

This bumps the minimum version of these two dependencies in order to pick
up the fix in #1150:

#1150

Signed-off-by: Ryan Goulding <goulding@layerzerolabs.org>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants