fix: update path in Solana readme #1146
Open
+9
−5
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nazreen
requested changes
Jan 6, 2025
|
|
||
| ``` | ||
| endpoint: <ENDPOINT_PROGRAM_ID> | ||
| oft: <OFT_PROGRAM_ID> | ||
| ``` | ||
|
|
||
| Copy the OFT's programId and go into [lib.rs](./programs/oft/src/lib.rs). Note the following snippet: | ||
| Copy the OFT's programId and go into [lib.rs](./programs/oft/src/lib.rs) (located inside this project under oft-solana/programs/oft/src/lib.rs). Note the following snippet: |
There was a problem hiding this comment.
@lzdane I don't think there's a need for the note in parentheses, the link already links to the right file. Devs can click on it. It's normal assumption that a filename with a link in a README links to a file in the same repo.
nazreen
reviewed
Jan 6, 2025
| @@ -210,7 +210,7 @@ pnpm hardhat lz:oft:solana:create --eid 40168 --program-id <PROGRAM_ID> | |||
|
|
|||
| :warning: Use `--additional-minters` flag to add a CSV of additional minter addresses to the Mint Authority Multisig. If you do not want to, you must specify `--only-oft-store true`. | |||
|
|
|||
| :information_source: You can also specify `--amount <AMOUNT>` to have the OFT minted to your deployer address upon token creation. | |||
| :information_source: You can also specify `--amount <AMOUNT>` to have the OFT minted to your deployer address upon token creation. Remember this is in local decimals, so with local decimals of 9, you would need to pass in `--amount1000000000` to mint 1 OFT. | |||
There was a problem hiding this comment.
thanks for adding this!
btw there's a space missing
amount1000000000
DanL0
reviewed
Jan 7, 2025
There was a problem hiding this comment.
I agree with @nazreen 's comments. If you address his comments this looks good to me.
Also please fix linting: https://github.com/LayerZero-Labs/devtools/actions/runs/12632527710/job/35196385732
We can't merge PR with failing CI checks.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.