PR feedback cleanup and basic bats test for build-lz-options version cli

Signed-off-by: Ryan Goulding <goulding@layerzerolabs.org>
LayerZero-Labs · Jan 26, 2024 · 3d0a667 · 3d0a667
1 parent e5d2583
commit 3d0a667
Show file tree

Hide file tree

Showing 7 changed files with 17 additions and 20 deletions.
diff --git a/packages/build-lz-options/package.json b/packages/build-lz-options/package.json
@@ -1,7 +1,6 @@
 {
   "name": "build-lz-options",
   "version": "0.0.1",
-  "private": true,
   "description": "Build LayerZero options with one command",
   "keywords": [
     "LayerZero",

diff --git a/packages/build-lz-options/src/components/config.tsx b/packages/build-lz-options/src/components/config.tsx
@@ -14,7 +14,7 @@ interface OptionType1Props {
   props: OptionType1Summary;
 }
 
-interface OptionType2Props extends OptionType1Props {
+interface OptionType2Props {
   props: OptionType2Summary;
 }
 

diff --git a/packages/build-lz-options/src/components/outputOptions.tsx b/packages/build-lz-options/src/components/outputOptions.tsx
@@ -9,7 +9,6 @@ interface OptionOutputProps {
 /**
  * Render the options output to the user.
  * @param {OptionOutputProps} props
- * @constructor
  */
 export const OutputOptions: React.FC<OptionOutputProps> = ({
   props,

diff --git a/packages/build-lz-options/src/index.tsx b/packages/build-lz-options/src/index.tsx
@@ -16,9 +16,11 @@ import {
 } from "@/components/config";
 import { OutputOptions } from "@/components/outputOptions";
 import { printLogo } from "@layerzerolabs/io-devtools/swag";
+import { version } from "../package.json";
 
 new Command("build-lz-options")
   .description("Create LayerZero OApp options with one command")
+  .version(version)
   .action(async () => {
     printLogo();
 

diff --git a/packages/build-lz-options/src/utilities/prompts.ts b/packages/build-lz-options/src/utilities/prompts.ts
@@ -143,22 +143,17 @@ const promptExecutorComposeOption = async (options: Options): Promise<Options> =
 const promptForExecutorOption = async (options: Options): Promise<Options> => {
     const executorOptionType = await promptForExecutorOptionType()
     switch (executorOptionType.type?.id) {
-        case ExecutorOptionType.LZ_RECEIVE: {
+        case ExecutorOptionType.LZ_RECEIVE:
             return promptExecutorLzReceiveOption(options)
-        }
-        case ExecutorOptionType.NATIVE_DROP: {
+        case ExecutorOptionType.NATIVE_DROP:
             return await promptExecutorNativeDropOption(options)
-        }
-        case ExecutorOptionType.COMPOSE: {
+        case ExecutorOptionType.COMPOSE:
             return await promptExecutorComposeOption(options)
-        }
-        case ExecutorOptionType.ORDERED: {
+        case ExecutorOptionType.ORDERED:
             return options.addExecutorOrderedExecutionOption()
-        }
-        default: {
+        default:
             // unreachable in normal operations
             throw new Error(`Unsupported executor option type: ${executorOptionType.type?.id}`)
-        }
     }
 }
 
@@ -181,16 +176,13 @@ export const promptForOptionType2 = (): Promise<OptionType2Summary> =>
 const determineWorkerType = async (options: Options): Promise<Options> => {
     const workerType = await promptForWorkerType()
     switch (workerType.type?.id) {
-        case WorkerId.EXECUTOR: {
+        case WorkerId.EXECUTOR:
             return promptForExecutorOption(options)
-        }
-        case WorkerId.VERIFIER: {
+        case WorkerId.VERIFIER:
             return promptVerifierPrecrimeOption(options)
-        }
-        default: {
+        default:
             // unreachable in normal operations
             throw new Error(`Unsupported worker type: ${workerType.type?.id}`)
-        }
     }
 }
 

diff --git a/packages/build-lz-options/tsconfig.json b/packages/build-lz-options/tsconfig.json
@@ -5,7 +5,7 @@
     "declaration": false,
     "jsx": "react",
     "lib": ["dom", "dom.Iterable", "es2022"],
-    "resolveJsonModule": false,
+    "resolveJsonModule": true,
     "types": ["node"],
     "paths": {
       "@/*": ["./src/*"],

diff --git a/tests-user/tests/build-lz-options.bats b/tests-user/tests/build-lz-options.bats
@@ -0,0 +1,5 @@
+
+
+@test "should output version" {
+    npx --yes build-lz-options --version
+}