Adding coroutines to analysis process #128
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Kordyjan
suggested changes
Apr 15, 2019
| import kotlinx.coroutines.runBlocking | ||
| import kotlin.coroutines.CoroutineContext | ||
|
|
||
| object KotlinCoroutinesScope : CoroutineScope { |
There was a problem hiding this comment.
I really don't like name of this object.
It can by KotlinAnalyzisScope or KotlinSupervisedScope if we want to use it somewhere else.
| @@ -30,13 +30,13 @@ import org.jetbrains.kotlin.progress.CompilationCanceledException | |||
| import org.jetbrains.kotlin.progress.CompilationCanceledStatus | |||
| import org.jetbrains.kotlin.progress.ProgressIndicatorAndCompilationCanceledStatus | |||
|
|
|||
| public class KotlinAnalysisJob(private val javaProject: IJavaProject) : Job("Kotlin Analysis") { | |||
There was a problem hiding this comment.
Remove this class as it doesn't have any purpose now.
| @@ -97,14 +100,18 @@ class KotlinBuilder : IncrementalProjectBuilder() { | |||
| val ktFiles = existingAffectedFiles.map { KotlinPsiManager.getParsedFile(it) } | |||
|
|
|||
| val analysisResultWithProvider = if (ktFiles.isEmpty()) | |||
| KotlinAnalyzer.analyzeProject(project) | |||
| runBlocking { | |||
There was a problem hiding this comment.
runBlocking here is completely unnecessary.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.