Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(v8) bump version to 11.4.183.23 #322

Merged
merged 2 commits into from
Jun 29, 2023
Merged

Conversation

casimiro
Copy link
Contributor

@casimiro casimiro commented Jun 28, 2023

Closes #304.

@@ -45,7 +45,7 @@ Options:
-A, --arch <arch> Architecture in 'uname -m' format (e.g. 'x86_64').
Defaults to the system's own.

-V, --runtime-ver <ver> Runtime version to build (e.g. '10.5.18')
-V, --runtime-ver <ver> Runtime version to build (e.g. '11.4.183.23')
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

we don't have to bump this one, but it felt weird not bumping it.

@hishamhm
Copy link
Contributor

V8 jobs in CI should pass when retriggered after https://github.com/Kong/ngx_wasm_runtimes/actions/runs/5405010992 finishes running!

@thibaultcha
Copy link
Member

thibaultcha commented Jun 29, 2023

Apparently also closes #299! We'll see on Monday, if it works it's going to be a huge release.

@thibaultcha
Copy link
Member

Oh we have that new release.sh option now! Perfect to quickly see if it'll fix it.

@thibaultcha thibaultcha merged commit 641c4b1 into main Jun 29, 2023
@thibaultcha thibaultcha deleted the chore/bump-v8-version branch June 29, 2023 02:58
@thibaultcha
Copy link
Member

Damn it, the CI on main didn't go well :( https://github.com/Kong/ngx_wasm_module/actions/runs/5408010328/jobs/9826640675

I didn't look too deep into it, considered the situation for a minute, and went with reverting the commit for now.

@thibaultcha
Copy link
Member

Well... Even #325 failed so I'm going to assume that the new build of V8 10.5.18 isn't quite exactly like the old one :/ Unfortunately, that means no more CI and no more merging for now... How come this happened? Did the V8 release builds change in-between this PR's CI running and the main branch CI running maybe?

@hishamhm hishamhm restored the chore/bump-v8-version branch June 29, 2023 13:08
@hishamhm hishamhm deleted the chore/bump-v8-version branch June 29, 2023 13:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

V8 trap handler support in ARM
3 participants