-
Notifications
You must be signed in to change notification settings - Fork 10
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore(v8) bump version to 11.4.183.23 #322
Conversation
@@ -45,7 +45,7 @@ Options: | |||
-A, --arch <arch> Architecture in 'uname -m' format (e.g. 'x86_64'). | |||
Defaults to the system's own. | |||
|
|||
-V, --runtime-ver <ver> Runtime version to build (e.g. '10.5.18') | |||
-V, --runtime-ver <ver> Runtime version to build (e.g. '11.4.183.23') |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
we don't have to bump this one, but it felt weird not bumping it.
V8 jobs in CI should pass when retriggered after https://github.com/Kong/ngx_wasm_runtimes/actions/runs/5405010992 finishes running! |
Apparently also closes #299! We'll see on Monday, if it works it's going to be a huge release. |
Oh we have that new |
Damn it, the CI on main didn't go well :( https://github.com/Kong/ngx_wasm_module/actions/runs/5408010328/jobs/9826640675 I didn't look too deep into it, considered the situation for a minute, and went with reverting the commit for now. |
Well... Even #325 failed so I'm going to assume that the new build of V8 |
Closes #304.