chore(release) minor quality-of-life tweaks #310
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
A matter of taste, but that flag builds both source and binary packages, and is "more powerful" than just "for i in * do --bin", so `--all` feels more appropriate. `--bin-all` still works for backwards compat / muscle memory. Plus a minor internal refactor to make it easier for the next person to spot that those flags are mutually exclusive.
hishamhm
force-pushed
the
chore/release.sh-match
branch
from
09e2a72 to
2a4b510
Compare
|
Nice this coveralls ran even after rebase then, that should have done it! |
|
Merged! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Inspired by work on #299 earlier this week, in particular:
With this PR the above becomes
./util/release.sh bla --all --match archlinux. Marginal change, but keepsgit statusclean, and I can see myself using it again in the future.Since I had to relearn how this script works since last time I used it, I figured I'd write a
--helpflag for my future self and ended up doing some more little tweaks in the process.