Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature: Xperience v29.7.0 support, docs format, file cleanup #34

Merged
merged 2 commits into from
Dec 3, 2024

Conversation

seangwright
Copy link
Member

Motivation

I was not able to generate the local database for the DancingGoat application, which was setup for v29.5.0.
When I replaced DancingGoat with a new v29.7.0 application I was able to generate the database so I'm sharing that code change.

  • Support Xperience v29.7.0
  • Remove developer environment setup settings from appsettings.json
  • Run dotnet format on solution
  • Ignore format and lint errors in DancingGoat project
  • Remove old .gitkeep files
  • Update non-Xperience NuGet packages to latest
  • Update required Xperience version in README.md

Checklist

  • Code follows coding conventions held in this repo
  • Automated tests have been added
  • Tests are passing
  • Docs have been updated (if applicable)
  • Temporary settings (e.g. variables used during development and testing) have been reverted to defaults

How to test

If manual testing is required, what are the steps?

Copy link
Contributor

@Rumec Rumec left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Review OK -> Approved

@Rumec Rumec merged commit 4375616 into main Dec 3, 2024
2 checks passed
@Rumec Rumec deleted the feat/xperience-29-07-00 branch December 3, 2024 13:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants