Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Migrate issue 235 #262

Merged
merged 19 commits into from
May 17, 2019
Merged

Migrate issue 235 #262

merged 19 commits into from
May 17, 2019

Conversation

kentico-anthonym
Copy link
Member

@kentico-anthonym kentico-anthonym commented May 16, 2019 •
edited by ChristopherJennings
Loading

Motivation

Which issue does this fix? Fixes #235

If no issue exists, what is the fix or new feature? Were there any reasons to fix/implement things that are not obvious?

Checklist

  • Code follows coding conventions held in this repo
  • Automated tests have been added
  • Tests are passing
  • Docs have been updated (if applicable)
  • Temporary settings (e.g. variables used during development and testing) have been reverted to defaults

How to test

If manual testing is required, what are the steps?

@kentico-anthonym kentico-anthonym marked this pull request as ready for review May 16, 2019 14:12
@ChristopherJennings ChristopherJennings self-assigned this May 16, 2019
ChristopherJennings
ChristopherJennings reviewed May 17, 2019
View reviewed changes
Copy link
Contributor

@ChristopherJennings ChristopherJennings left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I reviewed this and made a few changes 😉.

I added a test to make sure that instances installed to sub-directories still check the domain root since that's where the robots.txt should always be.

@ChristopherJennings ChristopherJennings merged commit a8cf318 into Kentico:v4-dev May 17, 2019
@kentico-anthonym kentico-anthonym deleted the migrate-issue-235 branch May 23, 2019 17:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ChristopherJennings ChristopherJennings ChristopherJennings left review comments

Assignees

@ChristopherJennings ChristopherJennings

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@kentico-anthonym @ChristopherJennings @amarquez914