Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: Added build and draft release job #17

Merged
merged 3 commits into from
Mar 6, 2024
Merged

Conversation

Nyoxis
Copy link
Collaborator

@Nyoxis Nyoxis commented Mar 5, 2024

For <tag> used package version, results in duplicate releases with the same name, if version wasn't bumped beforehand.

@Nyoxis Nyoxis marked this pull request as draft March 5, 2024 04:06
@kirushik kirushik changed the title CI: Added build and draft release job ci: Added build and draft release job Mar 5, 2024
@Nyoxis Nyoxis force-pushed the main branch 15 times, most recently from 609dee5 to 2f0ab46 Compare March 6, 2024 04:49
Added package version bump check
@Nyoxis
Copy link
Collaborator Author

Nyoxis commented Mar 6, 2024

For <tag> used package version, results in duplicate releases with the same name, if version wasn't bumped beforehand.

Added package version bump check, excluding this situation.

On pull request event, head and base branches are compared. On push event, this check compares current commit with the previous commit by SHA, thus resulting in comparing versions when commit --amend.

@Nyoxis Nyoxis marked this pull request as ready for review March 6, 2024 05:55
Copy link
Member

@kirushik kirushik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In principle, I'd rather have a is_version_greater.sh script which exits with a 0 exit code if it is indeed greater, and with a non-zero one if it's not. (Rather than putting those into the STDOUT and then comparing the values down the road.)

If it would be easy for you to fix — please do; if it will take more than, say, 30 minutes — let's add an issue to track this and merge this as it is.

Added package version bump check
@kirushik kirushik merged commit aca301b into Kalapaja:main Mar 6, 2024
5 of 8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants