Add options to filter out internal GC and dispatch frames #87
+175
−25
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
❗ Your organization is not using the GitHub App Integration. As a result you may experience degraded service beginning May 15th. Please install the Github App Integration for your organization. Read more. @@ Coverage Diff @@
## main #87 +/- ##
==========================================
+ Coverage 96.59% 96.99% +0.39%
==========================================
Files 3 3
Lines 294 333 +39
==========================================
+ Hits 284 323 +39
Misses 10 10
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
NHDaly
force-pushed
the
nhd-filter-internal-frames
branch
2 times, most recently
from
30fc804 to
be83b31
Compare
The GC frames are skipped by default now, since they make the GC graphs much less readable, and everyone basically always wants them skipped. I also refactored things a bit in the process, to allow for only checking these once per frame, and caching the result.
``` julia> PProf.Allocs.pprof() ┌ Info: 👋 Welcome to PProf! │ │ Consider trying `skip_jl_dispatch = true` as well, for a cleaner Graph view. │ The current options are best for the Flamegraph view. │ └ Now outputting your profile... Main binary filename not available. Serving web UI on http://localhost:62261 "alloc-profile.pb.gz" ```
NHDaly
force-pushed
the
nhd-filter-internal-frames
branch
from
6bfc861 to
2513042
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The GC frames are skipped by default now, since they make the GC graphs much less readable, and everyone basically always wants them skipped.
I also refactored things a bit in the process, to allow for only checking these once per frame, and caching the result.
This gives nicer graphs like this one, where the recursion here is real - this is a profile of julia's inference:
or this one:
I also added this message to tell you about the new flags
