Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use built-in function for combination reorder #85

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Use built-in function for combination reorder #85

wants to merge 1 commit into from

Conversation

milesfrain
Copy link

No description provided.

@mschauer mschauer closed this Nov 10, 2022
@mschauer mschauer reopened this Nov 10, 2022
@mschauer
Copy link
Member

There is a test error, it seems this doesn't work for strings

Test Failed at /home/runner/work/Combinatorics.jl/Combinatorics.jl/test/combinations.jl:4
[39](https://github.com/JuliaMath/Combinatorics.jl/actions/runs/3440436304/jobs/5738901006#step:6:42)
  Expression: [combinations("abc", 3)...] == [['a', 'b', 'c']]
[40](https://github.com/JuliaMath/Combinatorics.jl/actions/runs/3440436304/jobs/5738901006#step:6:43)
   Evaluated: ["abc"] == Array{Char,1}[['a', 'b', 'c']]

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@milesfrain @mschauer