-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: migrate to ESLint v9 and relevant packages #362
chore: migrate to ESLint v9 and relevant packages #362
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for getting started on this! 🙂
…eate-typescript-app
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #362 +/- ##
==========================================
+ Coverage 91.14% 95.50% +4.36%
==========================================
Files 12 11 -1
Lines 350 334 -16
Branches 42 42
==========================================
Hits 319 319
+ Misses 31 15 -16 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sorry, I don't think I was clear 😅. I'm requesting that this file be as close as possible to the latest ESLint configs I use in other repositories. The most recently created one is https://github.com/JoshuaKGoldberg/object-strings-deep/blob/41390065d3fa1f06d34bd2ed7d7c0320d8227ec6/eslint.config.js.
This is for two reasons:
- A lot of the settings in this repo's older ESLint config are no longer necessary. I commented a few of them inline to show examples.
- Soon, much of this will be automated, so any deviations from the other ESLint configs will cause extra work.
My advice would be to:
- Copy and paste the linked
eslint.config.js
here - Add or remove
devDependencies
as needed - Run
pnpm lint --fix
If any rules then start reporting complaints, you can either disable them in the config ("<rule-name>": "off"
) or fix them in the files. We can discuss those changes too if they're not straightforward.
Thanks!
Thanks, I updated it. Please help me re-review ❤️ |
I make 2 changes when compare with base eslint configuration file |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
💯 this looks great, thank you!
Agreed on all the decisions you made 🙂
PR Checklist
status: accepting prs
Overview