-
-
Notifications
You must be signed in to change notification settings - Fork 76
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add -v flag to display version #1063
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1063 +/- ##
=======================================
Coverage 94.17% 94.18%
=======================================
Files 96 96
Lines 5564 5571 +7
Branches 446 448 +2
=======================================
+ Hits 5240 5247 +7
Misses 323 323
Partials 1 1
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks like you're making good progress - and thanks for adding a test too! 🙌
Let me know if you need any help fixing up the last bits of complaints. https://github.com/JoshuaKGoldberg/create-typescript-app/blob/386bd14573d1ea1230e9adbe8436e935d7077c27/.github/DEVELOPMENT.md#development describes the things that are failing so far, and has a link at the top to a blog post too.
I think I fixed it? The issue was that my PR wasn't updated to the changes from the upstream repository, right? I kind of messed up and had to From the blog:
Once I do this step to update my local/origin main, do I need to |
Yup, exactly! Now that your Though, I think the lint errors are legit and not from some history weirdness. From the linked ❌ lint report:
The ESLint extension for your editor should be able to auto-fix that. Alternately, |
Ah I see 👀. I missed that when I was looking back at this PR, I just saw @codecov's report and thought it was just that my PR was not updated. Just ran Although now that I'm looking at the |
Great question! There are two kinds of tools folks often run as precommit hooks:
This repo template only runs Prettier as a commit hook. It doesn't run ESLint because:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
💯, perfect - thanks for this!
@all-contributors please add @xl4624 for code.
|
I've put up a pull request to add @xl4624! 🎉 I couldn't determine any contributions to add, did you specify any contributions? |
🎉 This is included in version v1.49.0 🎉 The release is available on: Cheers! 📦🚀 |
Adds @xl4624 as a contributor for code. This was requested by JoshuaKGoldberg [in this comment](#1063 (comment)) --------- Co-authored-by: allcontributors[bot] <46447321+allcontributors[bot]@users.noreply.github.com>
PR Checklist
status: accepting prs
Overview
I was browsing the list of issues labeled
good first issue
and saw that issue #704 had its attached PR closed. The version feature has basically already been implemented, but this just adds the flag to display the version.🧢