Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Adds Observed trait for checking an object is modified #53

Merged
merged 2 commits into from
Apr 28, 2024
Merged

Adds Observed trait for checking an object is modified #53

merged 2 commits into from
Apr 28, 2024

Conversation

Jerboa-app
Copy link
Contributor

Closes #49

@Jerboa-app
Adds Observed trait for checking an object is modified
7a7d889 
Used in content, disk files are hashed and check for
subsequent modifications by both checking a system
modification date (if present) and/otherwise the actual
files hash
Jerboa-app
Jerboa-app commented Apr 27, 2024
View reviewed changes
src/content/mod.rs Outdated Show resolved Hide resolved
@github-actions GitHub Actions
Copy link 

Looks like you increased coverage by 2.6 %, fantastic!
Here is the full report breakdown

Total coverage 19.05 % (+2.6 % against main)
_________________________________
src/config.rs                     | 0.0   % 0 / 14
src/filesystem/mod.rs             | 0.0   % 0 / 0
src/filesystem/observed.rs        | 0.0   % 0 / 0
src/main.rs                       | 0.0   % 0 / 15
src/server/api/mod.rs             | 0.0   % 0 / 0
src/server/api/stats.rs           | 0.0   % 0 / 81
src/server/http.rs                | 0.0   % 0 / 20
src/server/https.rs               | 0.0   % 0 / 85
src/server/mod.rs                 | 0.0   % 0 / 0
src/web/discord/mod.rs            | 0.0   % 0 / 0
src/web/discord/request/mod.rs    | 0.0   % 0 / 0
src/web/discord/request/model.rs  | 0.0   % 0 / 3
src/web/discord/request/post.rs   | 0.0   % 0 / 10
src/web/mod.rs                    | 0.0   % 0 / 30
src/web/response/mod.rs           | 0.0   % 0 / 0
src/web/response/util.rs          | 0.0   % 0 / 16
src/web/throttle.rs               | 0.0   % 0 / 48
src/web/stats.rs                  | 4.45  % 11 / 247
src/lib.rs                        | 11.76 % 2 / 17
src/content/resources/resource.rs | 20.0  % 3 / 15
src/content/pages/page.rs         | 28.21 % 11 / 39
src/filesystem/file.rs            | 37.5  % 15 / 40
src/content/mod.rs                | 53.33 % 24 / 45
src/util.rs                       | 58.93 % 33 / 56
src/filesystem/folder.rs          | 59.26 % 32 / 54
src/content/resources/mod.rs      | 75.0  % 15 / 20
src/content/pages/mod.rs          | 88.89 % 16 / 18
src/content/mime_type.rs          | 96.0  % 24 / 25
_________________________________

@Jerboa-app
Deprecate the file modified time
be2a684 
Does not seem to work when called in close succession
@github-actions GitHub Actions
Copy link 

Looks like you increased coverage by 4.79 %, fantastic!
Here is the full report breakdown

Total coverage 21.24 % (+4.79 % against main)
_________________________________
src/config.rs                     | 0.0   % 0 / 14
src/filesystem/mod.rs             | 0.0   % 0 / 0
src/filesystem/observed.rs        | 0.0   % 0 / 0
src/main.rs                       | 0.0   % 0 / 15
src/server/api/mod.rs             | 0.0   % 0 / 0
src/server/api/stats.rs           | 0.0   % 0 / 81
src/server/http.rs                | 0.0   % 0 / 20
src/server/https.rs               | 0.0   % 0 / 85
src/server/mod.rs                 | 0.0   % 0 / 0
src/web/discord/mod.rs            | 0.0   % 0 / 0
src/web/discord/request/mod.rs    | 0.0   % 0 / 0
src/web/discord/request/model.rs  | 0.0   % 0 / 3
src/web/discord/request/post.rs   | 0.0   % 0 / 10
src/web/mod.rs                    | 0.0   % 0 / 30
src/web/response/mod.rs           | 0.0   % 0 / 0
src/web/response/util.rs          | 0.0   % 0 / 16
src/web/throttle.rs               | 0.0   % 0 / 48
src/web/stats.rs                  | 4.45  % 11 / 247
src/lib.rs                        | 11.76 % 2 / 17
src/content/resources/resource.rs | 20.0  % 3 / 15
src/content/pages/page.rs         | 28.21 % 11 / 39
src/util.rs                       | 58.93 % 33 / 56
src/filesystem/folder.rs          | 59.26 % 32 / 54
src/filesystem/file.rs            | 72.73 % 24 / 33
src/content/resources/mod.rs      | 75.0  % 15 / 20
src/content/mod.rs                | 75.61 % 31 / 41
src/content/pages/mod.rs          | 88.89 % 16 / 18
src/content/mime_type.rs          | 100.0 % 25 / 25
_________________________________

@Jerboa-app Jerboa-app merged commit 46d5e0f into main Apr 28, 2024
6 checks passed
@Jerboa-app Jerboa-app deleted the add_observed branch May 5, 2024 08:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Observed trait
1 participant
@Jerboa-app