Add paged Atom feed option to search results #365
Conversation
There was a problem hiding this comment.
Hi @bondjimbond. Great work. I really like the idea of providing an atom feed as well as RSS. I made some comments of a few things I'd like to see changed in the code. All the comments really revolve around my thought that the ATOM display should be totally separate from the RSS display, in its hooks alters and function names, so the ATOM display can stand on its own.
| 'class' => 'IslandoraSolrResultsAtom', | ||
| 'function' => 'printAtom', | ||
| 'description' => t("Show search results as an Atom feed"), | ||
| 'logo' => '<img src="' . $path . '/images/rss.png" class="secondary-display-rss" alt="' . t("Atom Feed") . '">', |
There was a problem hiding this comment.
This should have its own image and class.
There was a problem hiding this comment.
Any suggestions for an Atom image?
#/media/File:Feed-icon.svg){kind=link}
There was a problem hiding this comment.
Its the same, when Atom was invented bitmaps where just a dream.... I would either go with the same or duplicate the file and give it another name so people could eventually decide for a replacement?
|
It looks like the code is failing travis on copy paste detection: I think that can probably be solved by reworking the ATOM feed to be its own thing, and not rely on the RSS item. Alternatively ATOM could use RSS as its base class. I think they are different enough to be completely separate though. |
|
@jonathangreen I think we may be there. Any further comments? |
JIRA Ticket: (https://jira.duraspace.org/browse/ISLANDORA-2440)
https://groups.google.com/d/topic/islandora/8eZCuy2NCCc/discussion
What does this Pull Request do?
Provides a new Secondary Display Profile option: Atom feed, an alternative to RSS with more features (especially paged results).
What's new?
The new Atom option rewrites the RSS output to make it compatible with Atom feed standards, and is offered as a new display profile. The Atom feed is paged and so can provide more results than the current Solr limit.
How should this be tested?
Additional Notes:
Currently using the RSS icon for the feed, which may be confusing if you're using both Atom and RSS -- although you shouldn't really be using both at the same time, should you? Open to alternative icons.
Interested parties
@Islandora/7-x-1-x-committers