Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix python-kadmin for testing #87

Merged
merged 1 commit into from
Apr 2, 2021
Merged

Fix python-kadmin for testing #87

merged 1 commit into from
Apr 2, 2021

Conversation

tucked
Copy link
Member

@tucked tucked commented Mar 31, 2021

8e187d3 switched the python-kadmin dep from rjancewicz/python-kadmin#59 to rjancewicz/python-kadmin#66; however, we now hit rjancewicz/python-kadmin#67. We need both PRs to fix this while maintaining py38 support, so I made tucked/python-kadmin#1 to do that. This switches the dep to use that.

@tucked tucked added the patch This change requires a Patch version bump. label Mar 31, 2021
@tucked tucked added this to the 4.0.4 milestone Mar 31, 2021
@ro-ket
Copy link
Collaborator

ro-ket commented Apr 1, 2021

@tucked do you have test results? I can't eyeball the guid 😊

@shirleylxie
Copy link
Collaborator

The fix works.
root@remotedev-sxie-rdu:/git/isilon_hadoop_tools# python3 -m tox -e py36 --devenv ./venv
py36 create: /git/isilon_hadoop_tools/venv
py36 installdeps: contextlib2 ~= 0.5.5, mock ~= 2.0.0, pytest ~= 4.3.0, pytest-cov ~= 2.6.1, pytest-randomly ~= 1.2.3, git+https://github.com/tucked/python-kadmin.git@fec2d339a64fe8912278f3ffc0b0d2f67ef8055f
py36 develop-inst: /git/isilon_hadoop_tools
py36 installed: atomicwrites==1.4.0,attrs==20.3.0,certifi==2020.12.5,chardet==4.0.0,contextlib2==0.5.5,coverage==5.5,future==0.18.2,idna==2.10,importlib-metadata==3.10.0,isi-sdk-7-2==0.2.11,isi-sdk-8-0==0.2.11,isi-sdk-8-0-1==0.2.11,isi-sdk-8-1-0==0.2.11,isi-sdk-8-1-1==0.2.11,isi-sdk-8-2-0==0.2.11,isi-sdk-8-2-1==0.2.11,isi-sdk-8-2-2==0.2.11,-e git+https://github.com/shirleylxie/isilon_hadoop_tools.git@238bf718e6eb439a49aca8d8d5ae29df95b176a6#egg=isilon_hadoop_tools,mock==2.0.0,more-itertools==8.7.0,pbr==5.5.1,pluggy==0.13.1,py==1.10.0,pytest==4.3.1,pytest-cov==2.6.1,pytest-randomly==1.2.3,python-dateutil==2.8.1,python-kadmin @ git+https://github.com/tucked/python-kadmin.git@fec2d339a64fe8912278f3ffc0b0d2f67ef8055f,requests==2.25.1,six==1.15.0,typing-extensions==3.7.4.3,urllib3==1.26.4,zipp==3.4.1

@shirleylxie
Copy link
Collaborator

root@remotedev-sxie-rdu:/git/isilon_hadoop_tools# cat tox.ini
[tox]

minversion = 3.7.0

isolated_build = true

envlist = py{27,35,36,37,38}-urllib3{121,default}

[testenv]

deps =
contextlib2 ~= 0.5.5
mock ~= 2.0.0
pytest ~= 4.3.0
pytest-cov ~= 2.6.1
pytest-randomly ~= 1.2.3
git+https://github.com/tucked/python-kadmin.git@fec2d339a64fe8912278f3ffc0b0d2f67ef8055f
urllib3121: urllib3 ~= 1.21.1

@tucked
Copy link
Member Author

tucked commented Apr 1, 2021

@ro-ket In this case, I think we can probably use the Travis results...

And if I botched this, it's purely test code.

@tucked tucked merged commit 3fd3aae into Isilon:master Apr 2, 2021
@tucked tucked deleted the kadmin branch April 2, 2021 00:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
patch This change requires a Patch version bump.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants