workaround ConcurrentModificationException when closeAllScopes in js #2032
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
luozejiaqun
force-pushed
the
bugfix/closeScopeConcurrentError
branch
from
515352f to
f649e59
Compare
|
can you propose something else? it seems a bit weird here to do that 🤔 |
|
@arnaudgiuliani just as i mentioned in #1963 , directly calling |
|
@luozejiaqun we could test fix with provided snippet. Seems same access problem as: #2058 |
| @@ -90,7 +90,9 @@ class ScopeRegistry(private val _koin: Koin) { | |||
| } | |||
|
|
|||
| private fun closeAllScopes() { | |||
| _scopes.values.toList().forEach { scope -> | |||
| // use another list to workaround ConcurrentModificationException | |||
| val scopes = List(_scopes.values.size) { _scopes.values.elementAt(it) } | |||
There was a problem hiding this comment.
This could work too:
_scopes.values.toTypedArray().forEach { scope ->
scope.close()
}
|
Let's see how 4.0.2-RC2 is going. Else let's reopen it 👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes gh-1963