-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
JSON Raw data processing #143
base: main
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
quelques retours
src/main/java/fr/insee/genesis/controller/dto/rawdata/LunaticJsonRawDataUnprocessedDto.java
Outdated
Show resolved
Hide resolved
src/main/java/fr/insee/genesis/controller/rest/responses/ResponseController.java
Outdated
Show resolved
Hide resolved
dataCount += surveyUnitModels.size(); | ||
} | ||
return ResponseEntity.ok("%d document(s) processed".formatted(dataCount)); | ||
}catch (GenesisException e){ //TODO replace with spring exception handler |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nice comment 🙃
src/main/java/fr/insee/genesis/controller/utils/ControllerUtils.java
Outdated
Show resolved
Hide resolved
src/main/java/fr/insee/genesis/domain/model/variabletype/VariableTypeModel.java
Outdated
Show resolved
Hide resolved
src/main/java/fr/insee/genesis/domain/service/rawdata/LunaticJsonRawDataService.java
Outdated
Show resolved
Hide resolved
|
||
@Data | ||
@Document(collection = Constants.MONGODB_VARIABLETYPE_COLLECTION_NAME) | ||
public class VariableTypeDocument { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Si mongo le permet je convertirais bien cette classe aussi en record
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Peut être dans un refacto général des documents
Ajout du traitement des données brutes JSON