ci: Private State and Environment

.swiftlint.yml

@@ -39,3 +39,29 @@ excluded:
  - Derived/
  - Tuist/.build/
  - Tuist/DerivedData/
+custom_rules:
+  private_state:
+    included:
+      - ".*\\.swift"
+    regex: "@State\\s+var"
+    message: "State should be private"
+  private_state_object:
+    included:
+      - ".*\\.swift"
+    regex: "@StateObject\\s+var"
+    message: "StateObject should be private"
+  private_modal_state:
+    included:
+      - ".*\\.swift"
+    regex: "@ModalState\\s+var"
+    message: "ModalState should be private"
+  private_environment:
+    included:
+      - ".*\\.swift"
+    regex: "@Environment\\([^)]*\\)\\s+var"
+    message: "Environment should be private"
+  private_environment_object:
+    included:
+      - ".*\\.swift"
+    regex: "@EnvironmentObject\\s+var"
+    message: "EnvironmentObject should be private"

Mail/Components/Custom Buttons/ModalButtonsView.swift

@@ -23,7 +23,7 @@ import SwiftUI
 struct ModalButtonsView: View {
     @Environment(\.dismiss) private var dismiss
 
-    @State var isButtonLoading = false
+    @State private var isButtonLoading = false
 
     let primaryButtonTitle: String
     var secondaryButtonTitle: String? = MailResourcesStrings.Localizable.buttonCancel

Mail/Views/Attachment/ActivityView.swift

@@ -19,7 +19,7 @@
 import SwiftUI
 
 struct ActivityView: UIViewControllerRepresentable {
-    @Environment(\.dismiss) var dismiss
+    @Environment(\.dismiss) private var dismiss
 
     let activityItems: [Any]
 

Mail/Views/Bottom sheets/RestoreEmailsView.swift

@@ -26,7 +26,7 @@ import MailResources
 import SwiftUI
 
 struct RestoreEmailsView: View {
-    @EnvironmentObject var mailboxManager: MailboxManager
+    @EnvironmentObject private var mailboxManager: MailboxManager
 
     @Environment(\.dismiss) private var dismiss
     @Environment(\.isCompactWindow) private var isCompactWindow

Mail/Views/LockedAppView.swift

@@ -26,7 +26,7 @@ import SwiftUI
 struct LockedAppView: View {
     @LazyInjectService var appLockHelper: AppLockHelper
 
-    @EnvironmentObject var navigationState: RootViewState
+    @EnvironmentObject private var navigationState: RootViewState
 
     @State private var isEvaluatingPolicy = false
 

Mail/Views/Menu Drawer/Folders/FolderCell.swift

@@ -40,8 +40,8 @@ struct FolderCell: View {
     @Environment(\.folderCellType) private var cellType
     @Environment(\.isCompactWindow) private var isCompactWindow
 
-    @EnvironmentObject var mainViewState: MainViewState
-    @EnvironmentObject var navigationDrawerState: NavigationDrawerState
+    @EnvironmentObject private var mainViewState: MainViewState
+    @EnvironmentObject private var navigationDrawerState: NavigationDrawerState
 
     let folder: NestableFolder
     var level = 0
@@ -131,7 +131,7 @@ struct FolderCellContent: View {
 
     @LazyInjectService private var matomo: MatomoUtils
 
-    @Environment(\.folderCellType) var cellType
+    @Environment(\.folderCellType) private var cellType
 
     private let frozenFolder: Folder
     private let level: Int

Mail/Views/Menu Drawer/MailboxManagement/MailboxesManagementView.swift

@@ -30,8 +30,8 @@ import SwiftUI
 struct MailboxesManagementView: View {
     @LazyInjectService private var matomo: MatomoUtils
 
-    @EnvironmentObject var mailboxManager: MailboxManager
-    @EnvironmentObject var navigationDrawerState: NavigationDrawerState
+    @EnvironmentObject private var mailboxManager: MailboxManager
+    @EnvironmentObject private var navigationDrawerState: NavigationDrawerState
 
     @Environment(\.currentUser) private var currentUser
 

Mail/Views/New Message/ComposeMessageView.swift

@@ -65,7 +65,7 @@ enum NewMessageAlertType {
 
 struct ComposeMessageView: View {
     @Environment(\.dismiss) private var dismiss
-    @Environment(\.dismissModal) var dismissModal
+    @Environment(\.dismissModal) private var dismissModal
     @EnvironmentObject private var mainViewState: MainViewState
 
     @LazyInjectService private var matomo: MatomoUtils

Mail/Views/Settings/General/SettingsNotificationsView.swift

@@ -37,7 +37,7 @@ struct SettingsNotificationsView: View {
 
     @AppStorage(UserDefaults.shared.key(.notificationsEnabled)) private var notificationsEnabled = DefaultPreferences
         .notificationsEnabled
-    @State var subscribedTopics: [String]?
+    @State private var subscribedTopics: [String]?
 
     @ModalState(context: ContextKeys.settings) private var showAlertNotification = false
     @State private var showWarning = false

Mail/Views/Thread List/ThreadListView.swift

@@ -46,8 +46,8 @@ struct ThreadListView: View {
     @ModalState private var isShowingUpdateAlert = false
     @ModalState private var flushAlert: FlushAlertState?
 
-    @StateObject var viewModel: ThreadListViewModel
-    @StateObject var multipleSelectionViewModel: MultipleSelectionViewModel
+    @StateObject private var viewModel: ThreadListViewModel
+    @StateObject private var multipleSelectionViewModel: MultipleSelectionViewModel
     @StateObject private var scrollObserver = ScrollObserver()
     @ObservedObject private var networkMonitor = NetworkMonitor.shared
 

Mail/Views/Thread/Message/Attachment/AttachmentsView.swift

@@ -30,7 +30,7 @@ import SwiftUI
 struct AttachmentsView: View {
     @LazyInjectService private var matomo: MatomoUtils
 
-    @EnvironmentObject var mailboxManager: MailboxManager
+    @EnvironmentObject private var mailboxManager: MailboxManager
     @ObservedRealmObject var message: Message
 
     @ModalState private var previewedAttachment: Attachment?

Mail/Views/Thread/Message/MessageHeader/MessageHeaderDetailView.swift

@@ -78,7 +78,7 @@ struct MessageHeaderDetailView: View {
 }
 
 struct RecipientLabel: View {
-    @EnvironmentObject var mailboxManager: MailboxManager
+    @EnvironmentObject private var mailboxManager: MailboxManager
 
     @Binding var labelWidth: CGFloat
     let title: String

MailCore/Utils/Constants.swift

@@ -31,6 +31,7 @@ public enum DeeplinkConstants {
 
     public static func presentsNotificationSettings() {
         @InjectService var platformDetector: PlatformDetectable
+        // swiftlint:disable:next private_environment
         @Environment(\.openURL) var openURL
 
         let settingsURL: URL?