feat: Edit and delete folders #1605
Conversation
BaptGrv
force-pushed
the
edit-folder-menu
branch
from
2c5c6b7 to
b899e7d
Compare
|
|
Found 0 unused code occurences Expand |
BaptGrv
force-pushed
the
edit-folder-menu
branch
from
18e49bf to
3a23bbd
Compare
BaptGrv
force-pushed
the
edit-folder-menu
branch
from
00c1d3a to
e24d162
Compare
| return try await perform(request: authenticatedRequest( | ||
| .modifyFolder(mailboxUuid: mailbox.uuid, folderId: folder.remoteId), | ||
| method: .post, | ||
| parameters: newName |
There was a problem hiding this comment.
You can use parameters directly instead of creating a struct
| parameters: newName | |
| parameters: ["name": name] |
| if folder != nil { | ||
| folderName = folder!.name | ||
| } | ||
| switch mode { | ||
| case .modify: | ||
| isModifyView = true | ||
| default: | ||
| return | ||
| } |
There was a problem hiding this comment.
Use init of the view instead of onAppear
| @@ -37,10 +37,13 @@ struct CreateFolderView: View { | |||
|
|
|||
| @State private var folderName = "" | |||
| @State private var error: FolderError? | |||
| @State private var isModifyView = false | |||
There was a problem hiding this comment.
You can check mode instead of declaring a new State
| if folder != nil && isModifyView { | ||
| await tryOrDisplayError { | ||
| try await mailboxManager.modifyFolder( | ||
| name: folderName, | ||
| folder: folder! | ||
| ) | ||
| } | ||
| } else { |
There was a problem hiding this comment.
Use guard to unwrap folder + directly check mode
| hasSubFolders = folders.contains { !$0.children.isEmpty } | ||
| } | ||
|
|
||
| var body: some View { | ||
| VStack(spacing: 0) { | ||
| ForEach(folders) { folder in | ||
|
|
|
|
||
| private let folders: [NestableFolder] | ||
| private let hasSubFolders: Bool | ||
| private let isUserFoldersList: Bool |
There was a problem hiding this comment.
Do not use isUserFoldersList but check for folder.role. If folder has a role do not allow rename.
| FolderCell(folder: folder, | ||
| currentFolderId: mainViewState.selectedFolder.remoteId, | ||
| canCollapseSubFolders: hasSubFolders, | ||
| matomoCategory: .menuDrawer) | ||
| .background(RoundedRectangle(cornerRadius: 10).fill(MailResourcesAsset.backgroundSecondaryColor.swiftUIColor)) |
There was a problem hiding this comment.
Check if we have a constant somewhere for cornerRadius
| } | ||
| } | ||
| } | ||
| .customAlert(isPresented: $isShowingCreateFolderAlert) { |
There was a problem hiding this comment.
Use .customAlert(item: $currentFolder) instead of a Bool + Folder for State
|
|
||
| @FocusState private var isFocused | ||
|
|
||
| let mode: Mode | ||
| let folder: Folder? |
There was a problem hiding this comment.
In an other comment I suggested adding an init. In the init you can use a default arg
There was a problem hiding this comment.
Wont be needed after my other comment
|
No description provided.