Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: SelectComposeMailboxView #1288

Merged
merged 59 commits into from
Apr 2, 2024
Merged

feat: SelectComposeMailboxView #1288

merged 59 commits into from
Apr 2, 2024

Conversation

Lnamw
Copy link
Contributor

@Lnamw Lnamw commented Feb 20, 2024

No description provided.

@Lnamw
Copy link
Contributor Author

Lnamw commented Feb 20, 2024

on hold, waiting for changes from UI designer

@Lnamw Lnamw added the on hold label Feb 20, 2024
@Lnamw Lnamw force-pushed the mailto branch 2 times, most recently from 936ad9e to 143ad7f Compare February 27, 2024 09:12
@Lnamw Lnamw force-pushed the mailto branch 2 times, most recently from ce05f62 to e8ea134 Compare February 29, 2024 10:23
@valentinperignon valentinperignon self-requested a review March 1, 2024 07:36
@Lnamw Lnamw force-pushed the mailto branch 4 times, most recently from 0cd3fc3 to ff4aa78 Compare March 6, 2024 12:37
@Lnamw Lnamw marked this pull request as ready for review March 6, 2024 12:56
@Lnamw Lnamw removed the on hold label Mar 6, 2024
@Lnamw Lnamw force-pushed the mailto branch 4 times, most recently from d518b8c to 8d3b1c0 Compare March 14, 2024 12:15
Copy link
Member

@valentinperignon valentinperignon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Juste a few comments 👍
Please, pull your branch as I rebased to be up to date with master

@Lnamw Lnamw force-pushed the mailto branch 2 times, most recently from 945ab4b to 8344006 Compare March 19, 2024 15:00
@valentinperignon
Copy link
Member

When we click on the button "Send with a different address", the button "continue" should be disabled

Lnamw added 10 commits March 25, 2024 08:47
# Conflicts:
#	Mail/Views/New Message/ComposeMessageIntentView.swift
#	MailShareExtension/ComposeMessageWrapperView.swift
# Conflicts:
#	Mail/Views/New Message/ComposeMessageIntentView.swift
#	Mail/Views/New Message/Header Cells/ComposeMessageSenderMenu.swift
#	MailShareExtension/ComposeMessageWrapperView.swift
Copy link

sonarqubecloud bot commented Apr 2, 2024

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

@valentinperignon valentinperignon merged commit d69230f into master Apr 2, 2024
6 checks passed
@valentinperignon valentinperignon deleted the mailto branch April 2, 2024 09:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants