Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Kdesktop 774 implementation of set rights method. #68

Merged
merged 74 commits into from
May 1, 2024
Merged

Kdesktop 774 implementation of set rights method. #68

merged 74 commits into from
May 1, 2024

Conversation

herve-er
Copy link
Contributor

@herve-er herve-er commented Apr 22, 2024 •
edited
Loading

Implement a cross-platform method for setting permissions on files and directories.

While std::filesystem::permission suffices for macOS and Linux, it's not suitable for managing permissions on Windows due to its use of ACL.

@herve-er herve-er self-assigned this Apr 22, 2024
@herve-er herve-er marked this pull request as ready for review April 23, 2024 13:48
@herve-er herve-er requested a review from a team as a code owner April 23, 2024 13:48
luc-guyot-infomaniak
luc-guyot-infomaniak reviewed Apr 23, 2024
View reviewed changes
Copy link
Contributor

@luc-guyot-infomaniak luc-guyot-infomaniak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would have expected to see some unit tests alongside this implementation. Is it scheduled?

Note: there is one change that is fix and which could be merged into the release branch. See comments.

src/libcommonserver/io/iohelper.cpp Outdated Show resolved Hide resolved
src/libcommonserver/io/iohelper.cpp Outdated Show resolved Hide resolved
src/libcommonserver/io/iohelper.h Outdated Show resolved Hide resolved
src/libcommonserver/io/iohelper_mac.cpp Show resolved Hide resolved
src/libcommonserver/io/iohelper_win.cpp Outdated Show resolved Hide resolved
src/server/appserver.cpp Outdated Show resolved Hide resolved
src/libcommonserver/io/iohelper_win.cpp Outdated Show resolved Hide resolved
src/libcommonserver/io/iohelper_win.cpp Outdated Show resolved Hide resolved
src/libcommonserver/io/iohelper_win.cpp Outdated Show resolved Hide resolved
src/libcommonserver/io/iohelper_win.cpp Outdated Show resolved Hide resolved
luc-guyot-infomaniak
luc-guyot-infomaniak reviewed Apr 29, 2024
View reviewed changes
src/libcommonserver/io/iohelper_win.cpp Outdated Show resolved Hide resolved
src/libsyncengine/propagation/executor/executorworker.cpp Outdated Show resolved Hide resolved
test/libcommonserver/io/testchecksetgetrights.cpp Outdated Show resolved Hide resolved
src/libcommonserver/io/iohelper_linux.cpp Outdated Show resolved Hide resolved
src/libcommonserver/io/iohelper_linux.cpp Outdated Show resolved Hide resolved
src/libcommonserver/io/iohelper_win.cpp Outdated Show resolved Hide resolved
src/libcommonserver/io/iohelper_win.cpp Outdated Show resolved Hide resolved
src/libcommonserver/io/iohelper_win.cpp Outdated Show resolved Hide resolved
src/libcommonserver/io/iohelper_win.cpp Outdated Show resolved Hide resolved
src/libcommonserver/io/iohelper_win.cpp Outdated Show resolved Hide resolved
@sonarqubecloud SonarQubeCloud
Copy link

sonarqubecloud bot commented May 1, 2024

Please retry analysis of this Pull-Request directly on SonarCloud

@herve-er herve-er merged commit b07e33f into develop May 1, 2024
6 checks passed
@herve-er herve-er deleted the KDESKTOP-774-Implementation-of-setRights-method branch May 1, 2024 07:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@luc-guyot-infomaniak luc-guyot-infomaniak luc-guyot-infomaniak approved these changes

@ChristopheLarchier ChristopheLarchier Awaiting requested review from ChristopheLarchier

Assignees

@herve-er herve-er

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@herve-er @ChristopheLarchier @luc-guyot-infomaniak