Improving Test Reliability in RemoteTemporaryDirectory and TestJobManager

[herve-er]

Issue 1: Naming Conflicts in RemoteTemporaryDirectory

RemoteTemporaryDirectory can encounter a FileAlreadyExist error due to naming conflicts in the following scenarios:

• Simultaneous test execution by two runners running the same test.
• Unnamed tests started within a 1-minute interval.

Solution:

• A random suffix is added to the directory name to significantly reduce the likelihood of collisions.
• In the rare case where a collision still occurs (e.g., simultaneous execution and matching random suffix), the error will be caught, and the system will retry with a new random suffix.

---

Issue 2: Flaky Test in TestJobManager::testCancelJobs

The TestJobManager::testCancelJobs test could fail randomly due to:

• Dependency on whether 100 upload jobs completed in less than 1 second.

Solution:

• Transition from relying on a predetermined wait time to a more robust approach:
  1. Wait for at least one job to complete.
  2. Immediately cancel all jobs.
  3. Wait for the jobManager queue to empty.
  4. Perform the existing checks.

This change not only improves test reliability but also reduces test execution time, eliminating the need for an arbitrary 11-second wait.

---

Issue 3: Flaky Test in testLog::testExpiredLogFiles

testLog::testExpiredLogFiles could fail randomly due to timing issues caused by too short wait for log expiration.

Solution:

Increased the time interval for log expiration to ensure adequate margin for the test environment. This change ensures stability and eliminates random failures.

[sonarqubecloud]

Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud