Optimization - Implementation of a cache on Snapshot::path() #435
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…-of-a-cache-on-Snapshot-path-
…-of-a-cache-on-Snapshot-path-
…-of-a-cache-on-Snapshot-path-
herve-er
requested changes
Dec 19, 2024
src/libsyncengine/update_detection/file_system_observer/snapshot/snapshotitem.h
Outdated
Show resolved
Hide resolved
|
I created a Jira card to implement a SnapshotCopy class, preventing unintended change of the snapshot copy that could lead to corruption of the cached path: KDESKTOP-1461. |
…-of-a-cache-on-Snapshot-path-
herve-er
previously approved these changes
Dec 20, 2024
…-Snapshot-path-' of github.com:Infomaniak/desktop-kDrive into KDESKTOP-1447-Optimization-Implementation-of-a-cache-on-Snapshot-path-
…-of-a-cache-on-Snapshot-path-
herve-er
reviewed
Dec 20, 2024
src/libsyncengine/update_detection/file_system_observer/snapshot/snapshot.cpp
Outdated
Show resolved
Hide resolved
herve-er
reviewed
Dec 20, 2024
src/libsyncengine/update_detection/file_system_observer/snapshot/snapshot.h
Outdated
Show resolved
Hide resolved
…-Snapshot-path-' of github.com:Infomaniak/desktop-kDrive into KDESKTOP-1447-Optimization-Implementation-of-a-cache-on-Snapshot-path-
…-of-a-cache-on-Snapshot-path-
|
ChristopheLarchier
deleted the
KDESKTOP-1447-Optimization-Implementation-of-a-cache-on-Snapshot-path-
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Time spent in ComputeFSOperationWorker::inferChangesFromDb for a 30 K items sync.
Without optimization:
2024-12-19 08:47:35:927 [D] (0x16ff9f000) utility.h:199 - Time counter inferChangesFromDb value:0.361502
2024-12-19 08:48:24:968 [D] (0x16ff9f000) utility.h:199 - Time counter inferChangesFromDb value:0.480998
2024-12-19 08:48:36:819 [D] (0x16ff9f000) utility.h:199 - Time counter inferChangesFromDb value:0.368319
2024-12-19 08:49:18:336 [D] (0x16ff9f000) utility.h:199 - Time counter inferChangesFromDb value:0.434929
2024-12-19 08:49:48:648 [D] (0x16ff9f000) utility.h:199 - Time counter inferChangesFromDb value:0.34866
Total: 1.994408
With optimization:
2024-12-19 08:21:38:232 [D] (0x16ff13000) utility.h:199 - Time counter inferChangesFromDb value:0.147962
2024-12-19 08:23:21:881 [D] (0x16fe87000) utility.h:199 - Time counter inferChangesFromDb value:0.1495
2024-12-19 08:24:52:519 [D] (0x1708eb000) utility.h:199 - Time counter inferChangesFromDb value:0.153976
2024-12-19 08:25:03:236 [D] (0x1708eb000) utility.h:199 - Time counter inferChangesFromDb value:0.149765
2024-12-19 08:30:26:941 [D] (0x1708eb000) utility.h:199 - Time counter inferChangesFromDb value:0.145286
Total: 0.746489
=> 63% improvement