Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Enables the logger to handle std::string directly #393

Merged
merged 15 commits into from
Nov 28, 2024
Merged

Enables the logger to handle std::string directly #393

merged 15 commits into from
Nov 28, 2024

Conversation

luc-guyot-infomaniak
Copy link
Contributor

No description provided.

@luc-guyot-infomaniak luc-guyot-infomaniak force-pushed the enable-the-removal-of-cstr-calls-in-log-messages branch 2 times, most recently from e574fac to 6f16672 Compare November 19, 2024 06:57
@luc-guyot-infomaniak luc-guyot-infomaniak marked this pull request as ready for review November 19, 2024 06:57
@luc-guyot-infomaniak luc-guyot-infomaniak requested a review from a team as a code owner November 19, 2024 06:57
@luc-guyot-infomaniak luc-guyot-infomaniak force-pushed the enable-the-removal-of-cstr-calls-in-log-messages branch from 6f16672 to ce4e167 Compare November 21, 2024 15:27
@luc-guyot-infomaniak luc-guyot-infomaniak added this to the 3.6.8 milestone Nov 22, 2024
@luc-guyot-infomaniak
Enables the logger to handle std::string directly
1e2e505
@luc-guyot-infomaniak
Re-use the custom logger stream string once it is computed
9237543
@luc-guyot-infomaniak
Fixes some variables scopes in log macros (build failures)
3b9779d
@luc-guyot-infomaniak
Fixes typo in macros causing build errors
edff61d
@luc-guyot-infomaniak
Adds semicolon after macro to fix build errors caused by macro expans…
2723a2c 
…ions
@luc-guyot-infomaniak
Fixes unit tests failure
3a1d8df
@luc-guyot-infomaniak
Fixes doc string as suggested by Sonar Cloud
76a08dd
@luc-guyot-infomaniak
Define testhelpers::setModificationDate for Windows
2f3a664
@luc-guyot-infomaniak
Fixes header file inclusion causing build error on Windows
9af123b
@luc-guyot-infomaniak
Adds missing include statements for Windows
2a4344d
@luc-guyot-infomaniak
Fixes typo in Windows struct name
00cdcab
@luc-guyot-infomaniak
Include missing header and use correct data members of _utimbuf on Wi…
9f5de8a 
…ndows
@luc-guyot-infomaniak
Fixes error introduced while rebasing wrt develop
8f62c04
@luc-guyot-infomaniak
Addresses one of the comment of Sonar Cloud: uses the Hidden Friend P…
07de4e8 
…attern
@luc-guyot-infomaniak
Removes irrelevent unit test files comitted accidentally (Clement CR …
5e6c5ae 
…comment)
@luc-guyot-infomaniak luc-guyot-infomaniak force-pushed the enable-the-removal-of-cstr-calls-in-log-messages branch from 9f0b177 to 5e6c5ae Compare November 27, 2024 07:57
@sonarqubecloud SonarQubeCloud
Copy link

Quality Gate Failed Quality Gate failed

Failed conditions
B Maintainability Rating on New Code (required ≥ A)

See analysis details on SonarQube Cloud

Catch issues before they fail your Quality Gate with our IDE extension SonarQube for IDE

@ClementKunz ClementKunz merged commit 85b379b into develop Nov 28, 2024
5 of 6 checks passed
@ClementKunz ClementKunz deleted the enable-the-removal-of-cstr-calls-in-log-messages branch November 28, 2024 10:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ClementKunz ClementKunz ClementKunz left review comments

@ChristopheLarchier ChristopheLarchier ChristopheLarchier approved these changes

@herve-er herve-er Awaiting requested review from herve-er

Assignees

@luc-guyot-infomaniak luc-guyot-infomaniak

Labels
None yet
Projects
None yet
Milestone
3.6.8
Development

Successfully merging this pull request may close these issues.
3 participants
@luc-guyot-infomaniak @ClementKunz @ChristopheLarchier