Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Kdesktop 1286 fix in executor worker upload session constructor #340

Conversation

herve-er
Copy link
Contributor

@herve-er herve-er commented Oct 8, 2024

We should provide a fileId instead of a filename for editing. Previously, it was functioning only due to the 'conflict=Version' argument in query parameters.

@herve-er herve-er requested a review from a team as a code owner October 8, 2024 12:24
@herve-er herve-er marked this pull request as draft October 8, 2024 12:28
@herve-er herve-er marked this pull request as ready for review October 8, 2024 12:28
Copy link

sonarqubecloud bot commented Oct 8, 2024

Quality Gate Failed Quality Gate failed

Failed conditions
2 Security Hotspots
0.0% Coverage on New Code (required ≥ 80%)
C Maintainability Rating on New Code (required ≥ A)
E Reliability Rating on New Code (required ≥ A)

See analysis details on SonarCloud

Catch issues before they fail your Quality Gate with our IDE extension SonarLint

@ClementKunz ClementKunz merged commit 05ba603 into develop Oct 8, 2024
5 of 6 checks passed
@ClementKunz ClementKunz deleted the KDESKTOP-1286-Fix-in-ExecutorWorker-UploadSession-constructor branch October 8, 2024 13:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants