Sonar cleaning.

Infomaniak · Apr 19, 2024 · e53c807 · e53c807
1 parent badd71e
commit e53c807
Show file tree

Hide file tree

Showing 3 changed files with 9 additions and 6 deletions.
diff --git a/src/gui/debuggingdialog.cpp b/src/gui/debuggingdialog.cpp
@@ -292,8 +292,8 @@ void DebuggingDialog::onSaveButtonTriggered(bool checked) {
 
 void DebuggingDialog::onSendLogButtonTriggered() {
     int size;
-    ExitCode exitCode = GuiRequests::getAproximateLogSize(size);
-    if (exitCode != ExitCode::ExitCodeOk) {
+
+    if (ExitCode exitCode = GuiRequests::getAproximateLogSize(size); exitCode != ExitCode::ExitCodeOk) {
         onSendLogConfirmed(true);  // Send all logs by default if we can't get the aproximate size
         return;
     }

diff --git a/src/libcommonserver/log/log.cpp b/src/libcommonserver/log/log.cpp
@@ -441,8 +441,11 @@ bool Log::compressLogs(const SyncPath &directoryToCompress, IoError &ioError, st
 bool Log::generateUserDescriptionFile(const SyncPath &outputPath, IoError &ioError) {
     SyncPath filePath = outputPath / "user_description.txt";
 
-    std::string osName, osArch, appVersion, userId;
-    // CommonUtility::getRunningOS(osName, osVersion, osArch);
+    std::string osName;
+    std::string osArch;
+    std::string appVersion;
+    std::string userId;
+
     osName = CommonUtility::platformName().toStdString();
     osArch = CommonUtility::platformArch().toStdString();
     appVersion = CommonUtility::userAgentString();

diff --git a/src/libcommonserver/log/log.h b/src/libcommonserver/log/log.h
@@ -178,14 +178,14 @@ class COMMONSERVER_EXPORT Log {
         bool generateLogsSupportArchive(bool includeOldLogs, const SyncPath &outputPath, const SyncPath &archiveName,
                                         IoError &ioError, std::function<void(int64_t)> progressCallback = nullptr);
 
-        bool generateUserDescriptionFile(const SyncPath &outputPath, IoError &ioError);  // TODO: set this method as private
-
     private:
         Log(const log4cplus::tstring &filePath);
         bool copyLogsTo(const SyncPath &outputPath, bool includeOldLogs, IoError &ioError);
         bool copyParmsDbTo(const SyncPath &outputPath, IoError &ioError);
         bool compressLogs(const SyncPath &directoryToCompress, IoError &ioError,
                           std::function<void(int64_t)> progressCallback = nullptr);
+        bool generateUserDescriptionFile(const SyncPath &outputPath, IoError &ioError); 
+
         static std::shared_ptr<Log> _instance;
         log4cplus::Logger _logger;
 };