Skipped tests that are not revelent without .parms.db

Infomaniak · May 6, 2024 · da36fef · da36fef
1 parent effc766
commit da36fef
Show file tree

Hide file tree

Showing 2 changed files with 32 additions and 0 deletions.
diff --git a/test/libcommonserver/log/testlog.cpp b/test/libcommonserver/log/testlog.cpp
@@ -132,13 +132,22 @@ void TestLog::testCopyLogsTo(void) {
 
 void TestLog::testCopyParmsDbTo(void) {
     {
+        if (!_parmsDbFileExist()) {
+            std::cout << std::endl << "No .parms.db file, this test will not be relevant (skipped)." << std::endl;
+            LOG_WARN(_logger, "No .parms.db file, this test will not be relevant (skipped).");
+            return;
+        }
+
         TemporaryDirectory tempDir;
         const SyncPath parmsDbName = ".parms.db";
         const SyncPath parmsDbPath = CommonUtility::getAppSupportDir() / parmsDbName;
 
         uint64_t parmsDbSize = 0;
         IoError err = IoErrorSuccess;
         IoHelper::getFileSize(parmsDbPath, parmsDbSize, err);
+
+
+
         CPPUNIT_ASSERT_EQUAL(IoErrorSuccess, err);
         CPPUNIT_ASSERT(parmsDbSize >= 0);
 
@@ -255,6 +264,12 @@ void TestLog::testGenerateUserDescriptionFile(void) {
 }
 
 void TestLog::testGenerateLogsSupportArchive(void) {
+    if (!_parmsDbFileExist()) {
+        std::cout << std::endl << "No .parms.db file, this test will not be relevant (skipped)." << std::endl;
+        LOG_WARN(_logger, "No .parms.db file, this test will not be relevant (skipped).");
+        return;
+    }
+
     {
         TemporaryDirectory tempDir;
         const SyncPath archiveFile = tempDir.path / "logs_support.tar.gz";
@@ -272,4 +287,18 @@ void TestLog::testGenerateLogsSupportArchive(void) {
     }
 }
 
+bool TestLog::_parmsDbFileExist() {
+    const SyncPath parmsDbName = ".parms.db";
+    const SyncPath parmsDbPath = CommonUtility::getAppSupportDir() / parmsDbName;
+
+    IoError err = IoErrorSuccess;
+    bool exists = false;
+
+    if (!IoHelper::checkIfPathExists(parmsDbPath, exists, err)) {
+        return false;
+    }
+
+    return exists;
+}
+
 }  // namespace KDC
diff --git a/test/libcommonserver/log/testlog.h b/test/libcommonserver/log/testlog.h
@@ -47,6 +47,9 @@ class TestLog : public CppUnit::TestFixture {
         void testCompressLogs(void);
         void testGenerateUserDescriptionFile(void);
         void testGenerateLogsSupportArchive(void);
+
+    private:
+        bool _parmsDbFileExist();
 };
 
 }  // namespace KDC