-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Create demo_config.yml #83
Conversation
and various file addresses/tests
fix typo
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It's looking ok, but I'm very concerned with the lack of validation of the configuration.
Co-authored-by: Diego Alonso Álvarez <6095790+dalonsoa@users.noreply.github.com>
Co-authored-by: Diego Alonso Álvarez <6095790+dalonsoa@users.noreply.github.com>
remove config load from swmmanywhere.swmmanywhere
…llegeLondon/SWMManywhere into 10-configuration-file
Thanks for the suggestions - if you wanted to specifically check the now added |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks much better. You should add a dedicated test for load_config
(not to test what jsonshema
is doing, but what the other bits and pieces are doing, but otherwise it looks good now.
Description
PR to implement configuration file, used to specify what to call from
swmmanywhere
Fixes #9 #10 #19
In part #28 - though switching
extension
is not yet included - this is listed under #28Notes:
swmmanywhere
function (is this a suitable name? conscious that it could confuse people's imports) reads aconfig
file and calls the various functions, including downloads (if necessary),graphfcns
,run
, andmetrics
.demo_config.yml
, currently used in testingiterate_graphfcns
anditerate_metrics
) iterate over both registers, currently within the respectiveutilities
modules.object
->id
in results/metricsassign_id
is now called at the start and end ofgraphfcn_list
, since SWMM cannot have edge names overlapping with node names (which in turn occurs due tosplit_long_edges
- now highlighted in Refactor split_long_edges #39 )This PR will not address:
inp
file read/write toswmmio
#84storevars
frommetric_list
. It seems possible but can have its own issue: see Calculatestorevars
frommetric_list
#85config
, I will bring over this functionality fromexperimenter.py
in Paper (ignore this) #79 under issue Sensitivity analysis sampling #86config
#88