expand ruff rules #73
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 6 commits
March 5, 2024 15:55
barneydobson
requested review from
cheginit and
dalonsoa
and removed request for
cheginit
cheginit
reviewed
Mar 5, 2024
swmmanywhere/graph_utilities.py
Outdated
| @@ -779,7 +773,7 @@ def __call__(self, G: nx.Graph, | |||
| # Push the neighbor to the heap | |||
| heappush(heap, (alt_dist, neighbor)) | |||
|
|
|||
| edges_to_keep = set() | |||
| edges_to_keep: set = set() # no clue why mypy wants me to do this.. | |||
There was a problem hiding this comment.
Maybe doing this will satisfy mypy: edges_to_keep: set[tuple[int, int]] = {}
cheginit
reviewed
Mar 5, 2024
Comment on lines
+111
to
+112
| existing_input_file = Path(__file__).parent / 'defs' /\ | ||
| 'basic_drainage_all_bits.inp' |
There was a problem hiding this comment.
I find using Path like so Path(Path(__file__).parent, 'defs', 'basic_drainage_all_bits.inp') to be more readable. I don't like using /. But if you prefer it this way, it's ok.
There was a problem hiding this comment.
I'm of the opposite opinion, I like / way more, so it is entirely up to you @barneydobson ! 😄
There was a problem hiding this comment.
Inertia probably means I'll leave it as is ;)
|
The rest looks good to me. |
Co-authored-by: Diego Alonso Álvarez <6095790+dalonsoa@users.noreply.github.com>
Co-authored-by: Diego Alonso Álvarez <6095790+dalonsoa@users.noreply.github.com>
…/ImperialCollegeLondon/SWMManywhere into 38-use-more-extensive-ruff-rules
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
implement new
ruffrulesFixes #38
Also replaces I think all of
oswithPath, related to #9 (I guess it doesn't quite close it because the validation part needs to come in somewhere... which probably won't be closed until we deal withconfig#10 )OK think I've implemented all of @cheginit 's suggestions for
pre-commit, the only thing I disabled was therefurbchaining suggestions, some of them seemed OK but some places there was (at least as far as I could see) no way to do chaining without making the code a lot less readable.