Fix add_dataset_file() to in 0.3.10 #118
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Change bod2 from list() to list(forceReplace = force) .
|
Thanks @Danny-dK -- this works with my example. Waiting on a few more tests and I'll merge soon. |
kuriwaki
changed the title
Closed
Closed
kuriwaki
approved these changes
Apr 9, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Change bod2 from list() to list(forceReplace = force) . The list() resulted in jsondata being run with '[]' which is not accepted within R anymore (unsure where the issue resulted from, could be either from httr, curl). The list(forceReplace = force) was already used at update_dataset_file(). Other option would be to use NULL instead of the list().
References #116 (comment)
(note: there were some issues with closing and renewing or changing base of pull request (automatically closed it), hope everything is good now)