Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CI Use actions upload-artifact and download-artifact v4 #795

Merged
merged 2 commits into from
Jan 2, 2025

Conversation

lesteve
Copy link
Collaborator

@lesteve lesteve commented Jan 2, 2025

download-artifact v4 supports downloading artifact from workflow run-id.

Closes #782 dependabot PR that was suggesting to update the dawidd6/action-download-artifact for security reasons.

Also artifact v3 is going to stop being supported end of January 2025 see https://github.blog/changelog/2024-04-16-deprecation-notice-v3-of-the-artifact-actions/.

I am trying to do some basic testing in my fork in lesteve#2 prior to merging.

This was referenced Jan 2, 2025
@lesteve
Copy link
Collaborator Author

lesteve commented Jan 2, 2025

Testing in my fork seems to work, let's merge this!

@lesteve lesteve changed the title MNT Use actions/download-artifact v4 that supports downloading artifact from workflow run-id MNT Use actions upload-artifact and download-artifact v4 Jan 2, 2025
@lesteve lesteve changed the title MNT Use actions upload-artifact and download-artifact v4 CI Use actions upload-artifact and download-artifact v4 Jan 2, 2025
@lesteve lesteve merged commit d434db9 into INRIA:main Jan 2, 2025
3 checks passed
@lesteve lesteve deleted the download-artifact-v4 branch January 2, 2025 16:14
github-actions bot pushed a commit to lesteve/scikit-learn-mooc that referenced this pull request Jan 3, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant