fix: nginx reverse proxy example #139
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
use variable instead of string literal
kadler
reviewed
Apr 4, 2024
| @@ -102,7 +102,7 @@ http { | |||
| ssl_session_cache shared:SSL:50m; | |||
| ssl_prefer_server_ciphers on; | |||
| location / { | |||
| proxy_pass http://node_servers; | |||
| proxy_pass http://$node_servers; | |||
There was a problem hiding this comment.
I'm not sure this is right. Our NGINX configs use the syntax without the $ and it all works fine. There seems to be some differences in how proxy_pass works with and without variables too. I'm having trouble finding anything definitive here, though.
There was a problem hiding this comment.
Ah I see if things are working fine no need to make the change then.
IIRC I was setting up a reverse proxy locally on Linux and used this as a guide to get it setup. Things were not working properly for me at the time until I put the $ in for the variable. That is what prompted me to open this PR.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
use variable instead of string literal
@ThePrez
I believe the intention here is to refer back the
node_seversvariable right?